1856145 - Error when trying to load any of betsoft.com games

Status: VERIFIED FIXED

(Core :: Audio/Video: Playback, defect)

Description

[Dwarf]

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:109.0) Gecko/20100101 Firefox/118.0

Steps to reproduce:

go to
https://betsoft.com/
choose from top menu
our games
pick a category (eg table games)
choose a game (Baccarat)
Select to Play Demo

Actual results:

error of
A network error error has occured. Please try again and contact support if the error persists

Expected results:

Game should play

Comment 1

[Dwarf]

Have run:
mozregression
it claims to have narrowed the issue down to:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=d1fbe6c1f87656fb4f55677904f55f6df433ea9a&tochange=062a5e5729067f579bd6d1ab2f1a3021d7fd291a

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

The Bugbug bot thinks this bug should belong to the 'Core::Audio/Video: Playback' component, and is moving the bug to that component. Please correct in case you think the bot is wrong.

Comment 3

[Mayank Bansal]

ni :padenot based on the regression range.

Comment 4

[Paul Adenot (:padenot)]

Some files (two in the example I've tried) on this website are invalid, and have a granulepos of 4294966502 for the last packet. At 44100Hz that is about 1.2 days. The file is only a few hundreds milliseconds long. This breaks the trimming logic, that trims the entire file. Empty files are reported as errors by decodeAudioData.

Comment 5

[Paul Adenot (:padenot)]

Attachment: Bug 1856145 - Protect against incorrect granulepos in OGG bytestream. r?alwu

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4ee0e2354b16
Protect against incorrect granulepos in OGG bytestream. r=alwu

Comment 7

[BugBot [:suhaib / :marco/ :calixte]]

Based on comment #1, this bug contains a bisection range found by mozregression. However, the Regressed by field is still not filled.

:padenot, if possible, could you fill the Regressed by field and investigate this regression?

For more information, please visit BugBot documentation.

Comment 8

[BugBot [:suhaib / :marco/ :calixte]]

This bug has been marked as a regression. Setting status flag for Nightly to affected.

Comment 9

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1839391

Comment 10

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/4ee0e2354b16

Comment 11

[Paul Adenot (:padenot)]

Comment on attachment 9356170 [details]
Bug 1856145 - Protect against incorrect granulepos in OGG bytestream. r?alwu

Beta/Release Uplift Approval Request

• User impact if declined: Content breakage -- gaming website doesn't work anymore
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: STR in https://bugzilla.mozilla.org/show_bug.cgi?id=1856145#c0
• List of other uplifts needed: None
• Risk to taking this patch: Medium
• Why is the change risky/not risky? (and alternatives if risky): This is special casing this case and reverts to previous behaviour.
• String changes made/needed:
• Is Android affected?: Yes

Comment 12

[Donal Meehan [:dmeehan]]

Comment on attachment 9356170 [details]
Bug 1856145 - Protect against incorrect granulepos in OGG bytestream. r?alwu

Approved for 119.0b6

Comment 13

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-beta/rev/e4271576d955

Comment 14

[Giorgia Nichita, Release Desktop QA]

Reproduced the issue on Firefox 118, on Ubuntu 22.
Verified as fixed on the latest Nightly 120.0a1 (20231005212657) and Firefox 119.0b6 (treeherder build - 20231004190537) on Ubuntu 22.04 and Ubuntu 20.04.

Comment 15

[Pascal Chevrel:pascalc (PTO until Sept 2)]

Comment on attachment 9356170 [details]
Bug 1856145 - Protect against incorrect granulepos in OGG bytestream. r?alwu

Approved for our next 118 dot release, thanks.

Comment 16

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-release/rev/92eea8706af0

Comment 17

[Pascal Chevrel:pascalc (PTO until Sept 2)]

https://hg.mozilla.org/releases/mozilla-release/rev/92eea8706af0

Comment 18

[Giorgia Nichita, Release Desktop QA]

Verified as fixed on Firefox 118.0.2 (20231009140911) on Ubuntu 22.04 and Ubuntu 20.04.