1856156 - Failing WPT in css/selectors/dir-pseudo-on-input-element.html

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, defect)

Description

[Thomas Wisniewski [:twisniewski]]

We're failing this test in https://wpt.fyi/results/css/selectors/dir-pseudo-on-input-element.html:

dynamic changes to type of input elements affect whether value is used for dir=auto

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

The severity field is not set for this bug.
:alaskanemily, could you have a look please?

For more information, please visit BugBot documentation.

Comment 2

[Vincent Hilla [:vhilla]]

While working on bug 1858084, I guess a fix might be to call OnValueChanged or SetDirectionFromValue somewhere here i.e. in HandleTypeChange for case VALUE_MODE_DEFAULT.

Comment 3

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1856156 - Recompute auto directionality on input type changes. r=smaug

Comment 4

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1856156 - Make Directionality an enum class. r=smaug,edgar,#dom-core

A bit neater this way.

Depends on D198588

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/14ed8bcf372c
Recompute auto directionality on input type changes. r=smaug
https://hg.mozilla.org/integration/autoland/rev/f23204fe8592
Make Directionality an enum class. r=smaug

Comment 6

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/14ed8bcf372c
https://hg.mozilla.org/mozilla-central/rev/f23204fe8592