1856243 - Scheduling.cpp: using mozilla::TimeStamp;

Status: RESOLVED FIXED

(Core :: JavaScript: GC, task, P3)

Description

[Sylvestre Ledru [:Sylvestre]]

Filling as a good first bug to learn workflows.

https://searchfox.org/mozilla-central/source/js/src/gc/Scheduling.cpp#31

 using decl 'TimeStamp' is unused 

Tutorial to contribute:
https://firefox-source-docs.mozilla.org/contributing/contribution_quickref.html
https://firefox-source-docs.mozilla.org/contributing/stack_quickref.html

Comment 1

[dpskhu13108]

Hi, I an outreachy applicant for december cohorot. I am interested in working with this issue. Please assign it to me.

Comment 2

[Sylvestre Ledru [:Sylvestre]]

it will be assigned to you as soon as you submit a patch for review :)

Comment 3

[anonymous0000007]

Hi, updateHighFrequencyMode method is using mozilla::TimeStamp

Comment 4

[Sylvestre Ledru [:Sylvestre]]

yeah, it is expected. mozilla:: is providing the namespace.

Comment 5

[anonymous0000007]

Hi, function is using TimeStamp then how can it be unused?

Comment 6

[Andrew McCreight [:mccr8]]

mozilla::TimeStamp is being used, so we still need the header include. If you click on the link in comment 0, you'll see this is about the using declaration using mozilla::TimeStamp;. This would let somebody write TimeStamp in this file, without the namespace mozilla, but TimeStamp is only used in this file with the explicit namespace, so the using is not needed.

Comment 7

[anonymous0000007]

Attachment: Bug 1856243 - Scheduling.cpp: using mozilla::TimeStamp; r=Sylvestre,willyelm

Comment 8

[anonymous0000007]

Thanks Andrew for clarity.

Comment 9

[anonymous0000007]

Hi, I submitted patch can someone review

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e638f7f57065
Scheduling.cpp: using mozilla::TimeStamp; r=sylvestre

Comment 11

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/e638f7f57065