1856267 - Clean up in IsComplexASCIIChar and IsComplexChar in nsLineBreaker

Status: RESOLVED FIXED

(Core :: Internationalization, task, P3)

Description

[Makoto Kato [:m_kato]]

Two issues.

• IsComplexASCIIChar is AL and NU. We can add IS and QU too.
• IsComplexChar is broken. It returns same result of IsComplexASCIIChar. So we can remove it.

Comment 1

[Makoto Kato [:m_kato]]

Attachment: Bug 1856267 - Don't use ICU4X segmenter if word is ASCII only and non-breakable character. r=TYLin

mCurrentWordContainsComplexChar and wordHasComplexChar seem to be used
whether a word is non-breakable character. I would like to rename it for clean
up.

Also, nsLineBreaker has a fast path if character is ASCII, alphabet (AL) and
number (NU). But IS and QU are also unbreakable. So we should add it by using
simple table.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d13725dac1c1
Don't use ICU4X segmenter if word is ASCII only and non-breakable character. r=TYLin,jfkthame

Comment 3

[Noemi Erli[:noemi_erli]]

Backed out changeset d13725dac1c1 (Bug 1856267) for causing failures in markup-src-1.html CLOSED TREE

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&group_state=expanded&collapsedPushes=842382&selectedTaskRun=NiRabVWnQiCZS5B12DIbQQ.0&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel&revision=d13725dac1c15841e3ae5265ac493e9cb7411dd1

Log: https://treeherder.mozilla.org/logviewer?job_id=432533160&repo=autoland&lineNumber=22669

Backout: https://hg.mozilla.org/integration/autoland/rev/e8068cf4fa90028d853f6f177070f15863f02b5e

Comment 4

[Makoto Kato [:m_kato]]

Attachment: Bug 1856267 - Consider incompatible breaking rules for old line segmenteri vs new line segmenter. r=TYLin

Even if ASCII, old line segmenter rules aren't compatible with UAX#14.
layout/reftests/line-breaking/markup-src-1.html runs on old segmenter prefs,
so we should use old non-breaking conditions for it with old segmenter.

Also, if word-break is break-all, we might have break opportunity for AL, NU,
IS, and QU combinations. So we should use ICU4X segmenter if break-all.

Depends on D190379

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/776ad5f12955
Don't use ICU4X segmenter if word is ASCII only and non-breakable character. r=TYLin,jfkthame
https://hg.mozilla.org/integration/autoland/rev/3cbd51f1e91c
Consider incompatible breaking rules for old line segmenteri vs new line segmenter. r=TYLin

Comment 6

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/776ad5f12955
https://hg.mozilla.org/mozilla-central/rev/3cbd51f1e91c