1856296 - Firefox Nightly window cannot be drag&dropped to relocate it on latest macOS 14 builds

Status: VERIFIED FIXED

(Core :: Widget: Cocoa, defect, P1)

Description

[Vlad Lucaci, Thunderbird QA (:vlucaci)]

Attachment: Screen Recording 2023-10-02 at 11.16.14.mov

Found in

• 120.0a1 (build ID 20231001214422)

Affected versions

• 120.0a1 (build ID 20231001214422)

Tested platforms

• Affected platforms: macOS 14.1(23B5046f) and macOS 14(23A344)
• Unaffected platforms: macOS 10.15, macOS 11, macOS 12, macOS 13

Steps to reproduce

1. Launch FF.
2. Attempt to drag&drop the FF window anywhere to relocate it.

Expected result

• The FF window moves wherever the user takes it with the drag and drop action.

Actual result

• The window is unresponsive and cannot be relocated anywhere using the drag and drop action.

Regression range

• First bad:2023-10-01
• Last good:2023-09-30
• Pushlog: link
• Potentially regressed by: 1855564

Additional notes

• This issue does not reproduce for other browsers or applications.
• This issue does not reproduce for other FF builds(Release, beta or DevEd)
• This issue does not reproduce for other macOS build versions(other than 14 and 14.1).
• We consider this issue to be an S2 since a very basic and important functionality(moving a browser window anywhere) is no longer working.

Comment 1

[Vlad Lucaci, Thunderbird QA (:vlucaci)]

Hello Mike,

it seems that 1855564 has caused this regression.

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1855564

Comment 3

[Jonny Barnes]

I’m running macOS 14(23A344) and I’m experiencing this bug

Comment 4

[Vlad Lucaci, Thunderbird QA (:vlucaci)]

After further investigation, it turns out that this issue is indeed occurring for both macOS 14.1(23B5046f) and macOS 14(23A344).
Thank you Jonny.

Comment 6

[Andrew McCreight [:mccr8]]

[Tracking Requested - why for this release]: basic browser UI feature of broken on MacOS 14 (the latest version that just released).

Comment 7

[Dianna Smith [:diannaS]]

requested backout bug 1855564 until this could be fixed

Comment 8

[Henrik Mitsch [:hmitsch]]

I hope this can be fixed before it hits beta or release. Many people's productivity will be severely impaired if it hits beta or release. It is much harder for me to work with Firefox in this state as I can't maximize screen estate or move my Firefox window to another screen. :-(

Comment 9

[Gian-Carlo Pascutto [:gcp]]

I hope this can be fixed before it hits beta or release

This is a release blocker. If this isn't an S1 I don't know what would be!

Comment 10

[Brad Werth [:bradwerth]]

I can reproduce on Sonoma beta. I'll try to figure this out such that when Bug 1855564 finally sticks, we won't have this bad behavior.

Comment 11

[Markus Stange [:mstange]]

We implement window dragging by setting up our NSView hierarchy in such a way that the NSViews in the back return YES from movableByWindowBackground, and then we place non-movable transparent NSViews in the non-movable regions of the window (they return NO from movableByWindowBackground). See here for more details.

We also have a hack here to avoid paints which might be causing problems and which might be unnecessary these days.

Comment 12

[Markus Stange [:mstange]]

When debugging this, I suggest the following approach: First, try to remove the call to ManipulateViewWithoutNeedingDisplay (just call mNonDraggableRegion.UpdateRegion directly). If that doesn't fix it, dump the NSView hierarchy starting at the window's border view ([[window contentView] superview]) along with each view's movableByWindowBackground property. There may also be a NSWindow styleMask flag that affects this behavior.

Comment 13

[Stephen A Pohl [:spohl] (OOO until 9/22)]

Adjusting Priority and Severity since bug 1855564 has been backed out.

Comment 14

[Markus Stange [:mstange]]

Fixed by backout of bug 1855564. Follow-up work will happen in bug 1856452.

Comment 15

[Vlad Lucaci, Thunderbird QA (:vlucaci)]

Confirming this issue as verified fixed on 120.0a1(20231002221644) using macOS 14.1(23B5046f) and 14(23A344)

Comment 16

[Henrik Mitsch [:hmitsch]]

It works like a charm! Thanks for fixing this so quickly. Team Firefox is fantastic! <3