1856370 - [wpt-sync] Sync PR 42282 - Fix "slicing" of outer box-shadows for inline fragments

Status: RESOLVED FIXED

(Core :: Layout: Images, Video, and HTML Frames, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 42282 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/42282
Details from upstream follow.

Fredrik Söderquist <[e-mail]> wrote:

Fix "slicing" of outer box-shadows for inline fragments

For outer box-shadows the shadow shape was not adjusted to take any
effects from "slicing" - i.e where an inline continues from a previous
line - into account, which resulted in incorrect rendering of the shadow
on those edges.

Reuse the existing AdjustRectForSideClipping() to perform this
adjustment, and refactor the clipping code slightly to clip correctly
for each shadow (it previously only applied for the first rendered
shadow).

Update a couple of tests that were previously incorrect.

Fixed: 1488440
Change-Id: If23b1d8095cef6d88ee808e4af3619a0ac70e9a3

Reviewed-on: https://chromium-review.googlesource.com/4900525
WPT-Export-Revision: 6b8d78123f7b866d378729f4827cac177b52c2e6

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=f67449a878e6683b11513a2344bcf60a4bf13353

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

CI Results

Ran 0 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 4 tests

Status Summary

Firefox

FAIL: 4

Chrome

FAIL: 4

Safari

PASS: 2
FAIL: 2

Links

GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

• /css/css-backgrounds/box-shadow/slice-block-fragmentation-001.html [wpt.fyi]: FAIL (Chrome: FAIL, Safari: PASS)
• /css/css-backgrounds/box-shadow/slice-block-fragmentation-002.html [wpt.fyi]: FAIL (Chrome: FAIL, Safari: PASS)
• /css/css-backgrounds/box-shadow/slice-inline-fragmentation-001.html [wpt.fyi]: FAIL (Chrome: FAIL, Safari: FAIL)
• /css/css-backgrounds/box-shadow/slice-inline-fragmentation-002.html [wpt.fyi]: FAIL (Chrome: FAIL, Safari: FAIL)

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6b550cbc7ff0
[wpt PR 42282] - Fix "slicing" of outer box-shadows for inline fragments, a=testonly

Comment 4

[Cristina Horotan [:chorotan]]

https://hg.mozilla.org/mozilla-central/rev/6b550cbc7ff0