1856398 - Notification bars are missing button colors

Status: VERIFIED FIXED

(Firefox :: Theme, defect)

Description

[Hanna Jones [:hjones]]

Attachment: Screenshot 2023-10-02 at 12.07.34 PM.png

Buttons are no longer displaying properly in notification infobars after the landing of Bug 1855429. Both the action button and close button styles are effectively missing. It seems like the button styles were dependent on those --in-content-* variables getting set on :host (the fact that notifications rely on in-content styles is a whole separate issue that will be addressed by Bug 1845150).

This can be easily replicated by navigating to https://permission.site/ and clicking on the "Popup (delayed 5 seconds)" button.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1855429

:emilio, since you are the author of the regressor, bug 1855429, could you take a look? Also, could you set the severity field?

For more information, please visit BugBot documentation.

Comment 2

[Emilio Cobos Álvarez (:emilio)]

How far along is bug 1845150? Read as... can we wait for that to land, or should I land some sort of hotfix here?

Comment 3

[Emilio Cobos Álvarez (:emilio)]

Attachment: WIP: Bug 1856398 - WIP of moz-message-bar.

Comment 4

[Emilio Cobos Álvarez (:emilio)]

I got to something like that in case it helps for the other bug, but there's still a bunch to do.

[Tracking Requested - why for this release]: We should make sure we don't ship the current state of the notifications.

Comment 5

[Hanna Jones [:hjones]]

(In reply to Emilio Cobos Álvarez (:emilio) from comment #2)

How far along is bug 1845150? Read as... can we wait for that to land, or should I land some sort of hotfix here?

The short answer is I think Bug 1845150 might take a while so a hotfix is probably best for now. Worst case I guess we could do something hack-y like the fix for Bug 1855546?

The long answer is the work on Bug 1845150 is a bit involved because we're trying to maintain the existing infobar styles while fully converting it to an HTMLElement that extends MozMessageBar. It'll likely depend on moz-button work in Bug 1791816 and possibly some follow ups to support accesskey underlining in buttons and links. Not having button styles in the chrome is kind of a complicating factor (though maybe we could use that .footer-button class 🤔).

I had gotten it to a point where things were kinda sorta working, with a lot more that would be fixed once we have moz-button which would provide both the proper button styles as well as allow us to set label on our button elements: https://hg.mozilla.org/try/rev/415bc2f8cc503bcec65cada5569aeb0e3c24825b

Those changes might be more extensive than necessary - I was kind of assuming we would run into issues using XUL labels/buttons in a Lit based HTMLElement, but that seems to be working fine in your WIP patch so I may go back to the drawing board and try to simplify a bit.

Comment 6

[Hanna Jones [:hjones]]

The code you shared made me curious so I more or less just combined that with some of the work I had done already to fix tests + keep similar styling and the work for Bug 1845150 may be closer than I thought. I still need to get proper button styles working (which may depend on moz-button) and accesskeys don't seem to totally work...but that may be a preexisting issue. WIP patch is up here: https://phabricator.services.mozilla.com/D189872

Comment 7

[BugBot [:suhaib / :marco/ :calixte]]

The bug is marked as tracked for firefox120 (nightly). However, the bug still isn't assigned.

:cbellini, could you please find an assignee for this tracked bug? Given that it is a regression and we know the cause, we could also simply backout the regressor. If you disagree with the tracking decision, please talk with the release managers.

For more information, please visit BugBot documentation.

Comment 8

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1856398 - Import in-content vars in notification-message. r=hjones,dao

Until the other bug is fixed.

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/00fb4b07d47e
Import in-content vars in notification-message. r=hjones

Comment 10

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/00fb4b07d47e

Comment 11

[Ardelean Oana, Desktop Test Engineering [:oardelean]]

Reproducible on a 2023-10-02 Nightly build on Windows 10.
Verified as fixed on Firefox 120.0b4 and Nightly 121.0a1 on Windows 10, Ubuntu 22, macOS 12.