Closed Bug 1856434 Opened 1 years ago Closed 1 year ago

Only show new Firefox Suggest suggestions for the default search engine

Categories

(Fenix :: Search, defect)

All
Android
defect

Tracking

(firefox119 wontfix, firefox120 verified)

VERIFIED FIXED
120 Branch
Tracking Status
firefox119 --- wontfix
firefox120 --- verified

People

(Reporter: lina, Assigned: lina)

References

(Blocks 1 open bug)

Details

(Whiteboard: [disco])

Attachments

(2 files)

Currently, suggestions from Firefox Suggest will always show up when enabled, even when you've selected a non-default search engine using the picker. On Desktop, they'll only be shown when searching with the default search engine. This bug tracks matching Desktop's behavior.

https://github.com/mozilla-mobile/firefox-android/pull/3708#discussion_r1333573518 has more context, with a breadcrumb for wiring up the Firefox Suggest provider to Fenix's SearchProviderState.

Whiteboard: [disco]
Type: task → defect
Summary: Integrate Firefox Suggest suggestions with unified search → Only show Firefox Suggest suggestions for the default search engine
Summary: Only show Firefox Suggest suggestions for the default search engine → Only show new Firefox Suggest suggestions for the default search engine

Authored by https://github.com/linabutler
https://github.com/mozilla-mobile/firefox-android/commit/e5e1baff4407aece2597b75dca952cb116e3ade2
[main] Bug 1856434 - Only show new Firefox Suggest suggestions for the default search engine.

Status: ASSIGNED → RESOLVED
Closed: 1 year ago
Flags: qe-verify+
Resolution: --- → FIXED
Target Milestone: --- → 120 Branch
Attached image 1856434.png

Verified as fixed on the latest Fenix Nightly 120.0a1 from 10/10 with the following devices:

  • Oppo Find N2 Flip (Android 13),
  • Xiaomi Mi8 Lite (Android 10).
Status: RESOLVED → VERIFIED
Flags: qe-verify+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: