1856459 - [wpt-sync] Sync PR 42294 - Revert "[fetch-later] Force sending when BackgroundSync permission is off"

Status: RESOLVED FIXED

(Core :: DOM: Networking, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 42294 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/42294
Details from upstream follow.

Jian Li <[e-mail]> wrote:

Revert "[fetch-later] Force sending when BackgroundSync permission is off"

This reverts commit d32dc3635147aa9cb4638864865aa6f86f42f2f2.

Reason for revert:
Caused consistent failures for virtual/fetch-later/wpt_internal/fetch/fetch-later/send-on-deactivate-with-background-sync.tentative.https.window.html

https://ci.chromium.org/ui/p/chromium/builders/ci/Mac10.15%20Tests/42380/overview

Original change's description:

[fetch-later] Force sending when BackgroundSync permission is off

The privacy decision suggests: after user navigates away from
a page, any pending requests left in the page should not be sent
if BackgroundSync permission is off (default is on in Chrome).

This CL forces sending out deferred requests on entering
BackForwardCache if the page's BackgroundSync permission is off.

Bug: 1465781
Change-Id: I120fbbc13294c40fcf13162d5d786f97e2131367
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4845750
Reviewed-by: Nidhi Jaju \<[e-mail]>
Auto-Submit: Ming-Ying Chung \<[e-mail]>
Reviewed-by: Xianzhu Wang \<[e-mail]>
Reviewed-by: Adam Rice \<[e-mail]>
Commit-Queue: Xianzhu Wang \<[e-mail]>
Cr-Commit-Position: refs/heads/main@{#1204080}

Bug: 1465781
Change-Id: I09e342e97d52745610d751eb21ee694ccf24976c
No-Presubmit: true
No-Tree-Checks: true
No-Try: true

Reviewed-on: https://chromium-review.googlesource.com/4908141
WPT-Export-Revision: a80dea5cd503277107c87a3a3e20a9b65c77e0ff

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

PR 42294 applied with additional changes from upstream: 5bd62ed6dee3fdb8fcdf35704203eb8e7eb410d2, 26d93762b77806b6623bfbcd9aed139d102c8f93

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=6d58cad4974a911943c59549feba8d4de17146f7

Comment 3

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

CI Results

Ran 9 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests

Status Summary

Firefox

ERROR: 1

Chrome

ERROR: 1

Safari

ERROR: 1

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

• /fetch/fetch-later/send-on-deactivate.tentative.https.window.html [wpt.fyi]: ERROR (Chrome: ERROR, Safari: ERROR)

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f1829ff5122c
[wpt PR 42294] - Revert "[fetch-later] Force sending when BackgroundSync permission is off", a=testonly

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/345bb12ad7c2
[wpt PR 42294] - Revert "[fetch-later] Force sending when BackgroundSync permission is off", a=testonly

Comment 6

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/345bb12ad7c2