1856470 - Add email tracking protection to AC

Status: RESOLVED FIXED

(Firefox for Android :: Privacy, task, P2)

Description

[[:harrisono]]

EngineSession.kt and TrackingProtectionPolicy.kt

Comment 1

[Arturo Mejia [:amejia]]

Hi Harrisono 👋,
Could add the priority and severity to this bug? :)

Comment 2

[BMO Github Automation]

Attachment: [mozilla-mobile/firefox-android] Bug 1856470 - Add EMAIL filter to TrackingCategory for tracker protection (#3980)

Comment 3

[BMO Github Automation]

Authored by https://github.com/HarrisonOg
https://github.com/mozilla-mobile/firefox-android/commit/d942833819a6f81fb46f70c9fadf346045c56643
[main] Bug 1856470 - Add EMAIL filter to TrackingCategory for tracker protection

Comment 4

[BMO Github Automation]

Attachment: [mozilla-mobile/firefox-android] Bug 1856470 - Add EMAIL filter to TrackingCategory for tracker protection (backport #3980) (#4536)

Comment 5

[Mira Lobontiu (Android QA)]

Hi!
Is there anything that the QA team can verify here?
Thank you!

Comment 6

[Chris Peterson [:cpeterson]]

IIUC, Jeff says we'll want to uplift this change to Beta 121 after some Nightly testing.

Comment 7

[Donal Meehan [:dmeehan]]

:harrisono there's a backport PR for this but we need an uplift request before taking it.

Comment 8

[[:harrisono]]

:dmeehan :cpeterson
hello! sorry I created the backport PR too early. Jeff and I decided to wait and let the original PR soak in nightly for the weekend and then process this uplift request today.

Comment 9

[[:harrisono]]

Comment on attachment 9364543 [details] [review]
[mozilla-mobile/firefox-android] Bug 1856470 - Add EMAIL filter to TrackingCategory for tracker protection (backport #3980) (#4536)

Beta/Release Uplift Approval Request

• User impact if declined: Email Tracker blocking will be delayed to next release cycle.
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): not risky as the change was already implemented in the GeckoView side in 121.
• String changes made/needed:
• Is Android affected?: Yes

Comment 10

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9364543 [details] [review]
[mozilla-mobile/firefox-android] Bug 1856470 - Add EMAIL filter to TrackingCategory for tracker protection (backport #3980) (#4536)

Approved for 121.0b5.

Comment 11

[BMO Github Automation]

Authored by https://github.com/HarrisonOg
https://github.com/mozilla-mobile/firefox-android/commit/44c6bd3d218227bb953d4c4eadaa0df75da8a7b4
[releases_v121] Bug 1856470 - Add EMAIL filter to TrackingCategory for tracker protection