1856497 - Focus movement between elements with the Tab key gets stuck somewhere. Once that happens, the Shift+Tab key also don't work at all.

Status: VERIFIED FIXED

(Core :: DOM: UI Events & Focus Handling, defect)

Description

[Alice0775 White]

Attachment: archive.zip for the record

[Tracking Requested - why for this release]: Broken [Tab] key navigation

Steps to reproduce:

1. Open https://syosetu.com/site/about/
2. Press and repeat [Tab] key

Steps to reproduce(with the attached zip file):

1. Unzip the attached zip to local file system
2. Drag and drop the unzipped 小説家になろうについて サイト案内 小説家になろう.htm from File Explorer into Tab content area.
3. Press and repeat [Tab] key

Actual Results:
Focus movement between elements with the Tab key gets stuck.
Once that happens, the Shift+Tab key also do not work at all.

Expected Results:
Focus movement between elements by tab key should cycle infinitely.

Regression window:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=7b7144975b319945642a90653847a06d03f111b7&tochange=e43370e4259f61e0c264dbcef8b45e2862b3c5e8

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

:emilio, since you are the author of the regressor, bug 1847929, could you take a look? Also, could you set the severity field?

For more information, please visit BugBot documentation.

Comment 2

[Alice0775 White]

Attachment: reduced testcase.html

Comment 3

[Alice0775 White]

Comment on attachment 9356283 [details]
reduced testcase.html

(edit 2023-10-12)
The attached testcase of comment#2 seems fixed by bug 1856514.
But str of comment#0 is still reproduced.

Comment 4

[Alice0775 White]

Attachment: testcase.html

deleted

Comment 5

[Alice0775 White]

FWIW,
Setting dom.input_events.security.minNumTicks to 0 also solve this issue.

Comment 6

[Emilio Cobos Álvarez (:emilio)]

That indicates that bug 1830820 is probably the root cause. My patch was probably overriding that for OOP iframes. Sean, maybe we just care about the top level page for the minNumTicks stuff?

Comment 7

[Sean Feng [:sefeng]]

In my opinion, we care both the top level and the nested documents. Though looks like this is not the problem.

It's likely that fixing bug 1856514 can also fix this. I'll do some testing.

Comment 8

[BugBot [:suhaib / :marco/ :calixte]]

The bug is marked as tracked for firefox119 (beta) and tracked for firefox120 (nightly). However, the bug still isn't assigned.

:hsinyi, could you please find an assignee for this tracked bug? Given that it is a regression and we know the cause, we could also simply backout the regressor. If you disagree with the tracking decision, please talk with the release managers.

For more information, please visit BugBot documentation.

Comment 9

[Sean Feng [:sefeng]]

Attachment: Bug 1856497 - Allow user input events to bypass the delay handling check if this is a non-visible document r=smaug

Comment 10

[Henri Sivonen (:hsivonen) (temporarily away from Bugzilla)]

S2, because this seems like it could trap keyboard-only users and this looks like a recent regression.

Comment 11

[Donal Meehan [:dmeehan]]

:sefeng we are in the last week of beta for Fx119. Will this land soon and can you add an uplift request when ready?

Comment 12

[Donal Meehan [:dmeehan]]

Setting Fx119 to Fixed, Bug 1858232 was uplifted to beta

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/03951bd1d784
Allow user input events to bypass the delay handling check if this is a non-visible document r=smaug

Comment 14

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/03951bd1d784

Comment 15

[Anca Soncutean, Desktop QA]

Reproduced with Fx 120.0a1 (2023-10-02) on Windows 10.
Verified fixed with Fx 120.a01 (2023-10-12) (treeherder build) and Fx 119.0b9 (treeherder build) on Windows 10.

Comment 16

[Sean Feng [:sefeng]]

Comment on attachment 9356735 [details]
Bug 1856497 - Allow user input events to bypass the delay handling check if this is a non-visible document r=smaug

Beta/Release Uplift Approval Request

• User impact if declined: User input may not be handled if dom.input_events.security.minNumTicks is not 0
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: Yes
• If yes, steps to reproduce:

1. Set dom.input_events.security.minNumTicks to 3
2. Use the STR in this bug.

• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): The change itself is trivial
• String changes made/needed:
• Is Android affected?: Yes

Comment 17

[Donal Meehan [:dmeehan]]

Comment on attachment 9356735 [details]
Bug 1856497 - Allow user input events to bypass the delay handling check if this is a non-visible document r=smaug

Approved for 119.0 RC1

Comment 18

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-beta/rev/2593adf517f5

Comment 19

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-esr115/rev/5e889b4373b9

Comment 20

[Anca Soncutean, Desktop QA]

Verified fixed with Fx 119.0 and Fx 115.4.0esr on Windows 10.