Consider to trigger minor GC before a page load
Categories
(Core :: DOM: Core & HTML, enhancement)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox120 | --- | fixed |
People
(Reporter: smaug, Assigned: smaug)
References
(Blocks 1 open bug)
Details
(Keywords: perf-alert, Whiteboard: [sp3])
Attachments
(1 file)
This depends on bug 1856574. Often a new page will run quite a bit JS, so Gecko could perhaps hint js engine when that is happening and run minor gc before that and increase nursery. (nursery size is after all rather small).
This is perhaps a bit controversial change but improves performance significantly.
Happy to tweak the patch.
|
||
Updated•9 months ago
|
|
Assignee | |
Comment 1•9 months ago
|
||
This doesn't cover all the page loads, need to run some more performance tests before using this everywhere.
Depends on D189917
|
||
Updated•9 months ago
|
Pushed by opettay@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/2d1ac29c2ae7 Consider to trigger minor GC before a page load, r=jonco
|
||
Comment 3•9 months ago
|
||
| bugherder | ||
|
||
Comment 4•9 months ago
|
||
(In reply to Pulsebot from comment #2)
Pushed by opettay@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/2d1ac29c2ae7
Consider to trigger minor GC before a page load, r=jonco
== Change summary for alert #39836 (as of Sat, 07 Oct 2023 13:07:23 GMT) ==
Improvements:
| Ratio | Test | Platform | Options | Absolute values (old vs new) | Performance Profiles |
|---|---|---|---|---|---|
| 4% | facebook LastVisualChange | linux1804-64-shippable-qr | fission warm webrender | 962.89 -> 923.51 | |
| 4% | sunspider | windows10-64-shippable-qr | fission webrender | 128.28 -> 123.28 | Before/After |
| 4% | amazon LastVisualChange | windows10-64-shippable-qr | bytecode-cached fission warm webrender | 1,036.67 -> 1,000.36 | Before/After |
| 3% | sunspider | linux1804-64-shippable-qr | fission webrender | 206.76 -> 199.60 | Before/After |
| 3% | ares6 | windows10-64-shippable-qr | fission webrender | 29.08 -> 28.26 | Before/After |
| ... | ... | ... | ... | ... | ... |
| 2% | speedometer | macosx1015-64-nightlyasrelease-qr | fission webrender | 166.25 -> 170.01 |
For up to date results, see: https://treeherder.mozilla.org/perfherder/alerts?id=39836
|
|
||
Updated•9 months ago
|
|
||
Comment 5•9 months ago
|
||
(In reply to Alexandru Ionescu (needinfo me) [:alexandrui] from comment #4)
(In reply to Pulsebot from comment #2)
Pushed by opettay@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/2d1ac29c2ae7
Consider to trigger minor GC before a page load, r=jonco== Change summary for alert #39836 (as of Sat, 07 Oct 2023 13:07:23 GMT) ==
Improvements:
Ratio Test Platform Options Absolute values (old vs new) Performance Profiles 4% facebook LastVisualChange linux1804-64-shippable-qr fission warm webrender 962.89 -> 923.51 4% sunspider windows10-64-shippable-qr fission webrender 128.28 -> 123.28 Before/After 4% amazon LastVisualChange windows10-64-shippable-qr bytecode-cached fission warm webrender 1,036.67 -> 1,000.36 Before/After 3% sunspider linux1804-64-shippable-qr fission webrender 206.76 -> 199.60 Before/After 3% ares6 windows10-64-shippable-qr fission webrender 29.08 -> 28.26 Before/After ... ... ... ... ... ... 2% speedometer macosx1015-64-nightlyasrelease-qr fission webrender 166.25 -> 170.01 For up to date results, see: https://treeherder.mozilla.org/perfherder/alerts?id=39836
== Change summary for alert #39861 (as of Mon, 09 Oct 2023 05:35:33 GMT) ==
Improvements:
| Ratio | Test | Platform | Options | Absolute values (old vs new) | Performance Profiles |
|---|---|---|---|---|---|
| 2% | speedometer3 | macosx1300-64-shippable-qr | fission webrender | 15.01 -> 15.38 | Before/After |
| 2% | speedometer3 | windows10-64-nightlyasrelease-qr | fission webrender | 13.21 -> 13.51 | Before/After |
| 2% | speedometer | macosx1015-64-shippable-qr | fission webrender | 169.63 -> 173.24 | Before/After |
For up to date results, see: https://treeherder.mozilla.org/perfherder/alerts?id=39836
Description
•