Closed Bug 1856596 Opened 1 year ago Closed 8 months ago

The Cards from the Shopping sidebar do not have borders in HCM on Mac and Ubuntu

Categories

(Firefox :: Shopping, enhancement, P3)

Product:
Firefox
Component:
Shopping
Platform:
Desktop
macOS
Type:
enhancement

Tracking

()

Status:
RESOLVED FIXED
Milestone:
129 Branch
Tracking Flags:
Tracking Status
firefox-esr115 --- disabled
firefox-esr128 --- disabled
firefox118 --- disabled
firefox119 --- disabled
firefox120 --- disabled
firefox127 --- disabled
firefox128 --- disabled
firefox129 --- verified

People

(Reporter: rdoghi, Assigned: jhirsch)

References

(Blocks 1 open bug)

Details

(Keywords: access, Whiteboard: [fidefe-shopping])

Attachments

(5 files)

Bug 1856596 - Add shopping card borders in mac/linux high contrast mode. r?niklas,gijs
48 bytes, text/x-phabricator-request
Details | Review
Mac - current sidebar with Increased Contrast
282.62 KB, image/png
Details
Mac - sidebar with patch applied in Increased Contrast mode
274.66 KB, image/png
Details
Windows 11 - sidebar in current nightly in "Aquatic" High Contrast theme
140.52 KB, image/png
Details
Windows 11 - sidebar with patch applied in "Aquatic" high contrast theme
140.87 KB, image/png
Details

Found in

  • Beta 119.0b3

Affected versions

  • Beta 119.0b3
  • Nightly 120.0a1 (2023-10-02)

Affected platforms

  • MAC, Ubuntu

Preconditions:
Set the browser.shopping.experience2023.enabled - TRUE
Set the browser.shopping.experience2023.optedIn - 1
Enable High Contrast on MAC or Ubuntu

Steps to reproduce

  1. Reach amazon.com and reach any product details page that has reviews.

Expected result

  • The cards from the Shopping sidebar should have Borders on MacOs and Ubuntu similar to Windows.

Actual result

  • The cards from the Shopping sidebar do not show any borders.

Please note that the Onboarding card from the Shopping sidebar does show a border. I'm not sure which behavior is correct should we see the borders on the cards or not ?

Regression range
Not Applicable

status-firefox119: affected → wontfix
Priority: -- → P3
Blocks: 1855469
Assignee: nobody → achurchwell
Blocks: 1861074
No longer blocks: 1855469
Assignee: achurchwell → jhirsch
Status: NEW → ASSIGNED

Here's a screenshot of the current sidebar in Mac with Increased Contrast enabled

Pushed by jhirsch@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/20a453534342 Add shopping card borders in mac/linux high contrast mode. r=Gijs,desktop-theme-reviewers,dao

https://hg.mozilla.org/mozilla-central/rev/20a453534342

Status: ASSIGNED → RESOLVED
Closed: 8 months ago
status-firefox129: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 129 Branch

This issue is verified as fixed in our latest Nightly build 129.0a1 (2024-06-24)

status-firefox127: --- → affected
status-firefox128: --- → affected
status-firefox129: fixed → verified
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: