Closed Bug 1856682 Opened 2 years ago Closed 2 years ago

[wpt-sync] Sync PR 42315 - Fix :dir() selector and updates for dir=auto and descendant directionality to consider non-HTML elements.

Categories

(Core :: DOM: Core & HTML, task, P4)

Product:
Core
Component:
DOM: Core & HTML
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
121 Branch
Tracking Flags:
Tracking Status
firefox121 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 42315 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/42315
Details from upstream follow.

L. David Baron <dbaron@chromium.org> wrote:

Fix :dir() selector and updates for dir=auto and descendant directionality to consider non-HTML elements.

This changes behavior only when the CSSPseudoDir flag is enabled.

This is based on the proposed behavior described in:
https://github.com/whatwg/html/issues/3699#issuecomment-951423468
which is in the process of being specified in:
https://github.com/whatwg/html/pull/9554
https://github.com/whatwg/html/pull/9796
and on the behavior specified in:
https://drafts.csswg.org/selectors-4/#the-dir-pseudo

Bug: 576815
Change-Id: I57323aeda8850f382756cd36b3717d34e8911f5e
Reviewed-on: https://chromium-review.googlesource.com/4908695
WPT-Export-Revision: bf0072146eaafd9863d7ec641bb89f75df411a66

Component: web-platform-tests → DOM: Core & HTML
Product: Testing → Core

CI Results

Ran 8 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 2 tests and 8 subtests

Status Summary

Firefox

OK : 2
PASS: 5
FAIL: 10

Chrome

OK : 2
PASS: 9
FAIL: 6

Safari

OK : 2
PASS: 7
FAIL: 8

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

Firefox-only Failures

New Tests That Don't Pass

  • /html/dom/elements/global-attributes/dir-assorted.window.html [wpt.fyi]
    • Non-HTML element outside the document tree has a direction: FAIL (Chrome: FAIL, Safari: FAIL)
    • Non-HTML element without direction has parent element direction: FAIL (Chrome: FAIL, Safari: FAIL)
    • Non-HTML element text contents influence dir=auto: FAIL (Chrome: FAIL, Safari: FAIL)
  • /html/dom/elements/global-attributes/dir-auto-dynamic-changes.window.html [wpt.fyi]
    • dir=auto changes for content insertion and removal, in and out of document: FAIL (Chrome: PASS, Safari: PASS)
    • dir=auto changes for slot reassignment: FAIL (Chrome: FAIL, Safari: FAIL)
    • text changes affecting both slot and ancestor with dir=auto: FAIL (Chrome: PASS, Safari: FAIL)
    • dynamic changes to subtrees excluded as a result of the dir attribute: FAIL (Chrome: PASS, Safari: PASS)
    • dynamic changes inside of non-HTML elements: FAIL (Chrome: FAIL, Safari: FAIL)
    • slotted non-HTML elements: FAIL (Chrome: PASS, Safari: FAIL)
    • slotted non-HTML elements after dynamically assigning dir=auto, and dir attribute ignored on non-HTML elements: FAIL (Chrome: FAIL, Safari: FAIL)
Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/28cd492bf061 [wpt PR 42315] - Fix :dir() selector and updates for dir=auto and descendant directionality to consider non-HTML elements., a=testonly https://hg.mozilla.org/integration/autoland/rev/aac145262d32 [wpt PR 42315] - Update wpt metadata, a=testonly

https://hg.mozilla.org/mozilla-central/rev/28cd492bf061
https://hg.mozilla.org/mozilla-central/rev/aac145262d32

Status: NEW → RESOLVED
Closed: 2 years ago
status-firefox121: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 121 Branch
You need to log in before you can comment on or make changes to this bug.