1856722 - [wpt-sync] Sync PR 42227 - gamepad: Check that the DocumentLoader is not null

Status: RESOLVED FIXED

(Core :: DOM: Editor, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 42227 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/42227
Details from upstream follow.

Matt Reynolds <[e-mail]> wrote:

gamepad: Check that the DocumentLoader is not null

Gamepad timestamps are reported relative to the navigationStart
timestamp, accessed from the DocumentLoader's DocumentLoadTiming.
In some scenarios the document may have been detached before the
NavigatorGamepad is initialized, causing the DocumentLoader to be
nullptr.

This CL checks that the DocumentLoader is non-null, and uses the
current time in place of navigationStart if it is null.

Bug: 1483777
Change-Id: Ib3efcf3a612cd4c1c543218fa5fb8568c7129dcf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4899018
Reviewed-by: Alvin Ji \<[e-mail]>
Commit-Queue: Matt Reynolds \<[e-mail]>
Cr-Commit-Position: refs/heads/main@{#1204813}

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=079971e048c8448c0ab5847ae8287d69df28054d

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

CI Results

Ran 11 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests

Status Summary

Firefox

TIMEOUT: 1

Chrome

CRASH : 1

Safari

PASS : 1

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

• /editing/crashtests/insertAdjacentElement-with-DOMSubtreeModified.html [wpt.fyi]: TIMEOUT (Chrome: CRASH, Safari: PASS)

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/cac8106701fe
[wpt PR 42227] - gamepad: Check that the DocumentLoader is not null, a=testonly
https://hg.mozilla.org/integration/autoland/rev/c69d0eea70e8
[wpt PR 42227] - Update wpt metadata, a=testonly

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/bd7b3f9a7398
[wpt PR 42227] - gamepad: Check that the DocumentLoader is not null, a=testonly
https://hg.mozilla.org/integration/autoland/rev/117a37d436ce
[wpt PR 42227] - Update wpt metadata, a=testonly

Comment 5

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/bd7b3f9a7398
https://hg.mozilla.org/mozilla-central/rev/117a37d436ce