Closed Bug 1856731 Opened 1 year ago Closed 1 year ago

Remove background script requirement to show reader mode

Categories

(Fenix :: WebExtensions, task, P1)

All
Android
task

Tracking

(firefox120 verified)

VERIFIED FIXED
120 Branch
Tracking Status
firefox120 --- verified

People

(Reporter: boek, Assigned: boek)

References

(Regressed 1 open bug)

Details

(Whiteboard: [fxdroid][foundation][geckoview:m119])

Attachments

(1 file)

With the move to the extensions process we don't want to require the background script to present reader mode. This will be a temporary measure until we migrate to AboutReader in GeckoView.

Duplicate of this bug: 1856708
Assignee: nobody → jboek

Authored by https://github.com/boek
https://github.com/mozilla-mobile/firefox-android/commit/891d124ddb387705dbf77f9f946a73620179a6f0
[main] Bug 1856731 - Moves showing reader mode from the content / background script to the Feature. (#3922)

Status: NEW → RESOLVED
Closed: 1 year ago
Flags: qe-verify+
Resolution: --- → FIXED
Target Milestone: --- → 120 Branch

Verified on the latest Fenix Nightly 120.0a1 from 10/17 with:

  • Xiaomi Mi8 Lite (Android 10), and
  • Samsung Galaxy Tab S8 Ultra (Android 12).

The following scenarios were tested:

  • enabling reader mode,
  • modifiyng the appearance (dark, sepia, white, +/-),
  • scrolling, sending the app in the background, re-opening Fenix, observing the scrolling position and if the reader mode appearance is preserved,
  • disabling the reader mode.
Status: RESOLVED → VERIFIED
Flags: qe-verify+
Regressions: 1860740
Regressions: 1863662
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: