1856942 - Abstract details of `Loader::LoadSheet` away

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, enhancement)

Description

[Mirko Brodesser (:mbrodesser-Igalia)]

Afterwards, extending it is safer.

Comment 1

[Mirko Brodesser (:mbrodesser-Igalia)]

Attachment: Bug 1856942: part 1) Rename `IncrementOngoingLoadCount` to `IncrementOngoingLoadCountAndMaybeBlockOnload`. r=emilio

Emilio: perhaps take a look at all patches of this bug first before
commenting.

Comment 2

[Mirko Brodesser (:mbrodesser-Igalia)]

Attachment: Bug 1856942: part 2) Factor sync loading of sheet out of `Loader::LoadSheet`. r=emilio

In another patch, ::LoadSheet needs to be extended to support the
fetchpriority attribute (see
https://bugzilla.mozilla.org/show_bug.cgi?id=1839315).

Loader::LoadSheet is already 350 lines long
(https://searchfox.org/mozilla-central/rev/29bdf6ff9965a647c6f64d63fed2b5bd094532c7/layout/style/Loader.cpp#1147-1495).
To avoid further growing Loader::LoadSheet, details are abstract away
in this and following parts.

This is in line with
https://google.github.io/styleguide/cppguide.html#Write_Short_Functions.

Depends on D190044

Comment 3

[Mirko Brodesser (:mbrodesser-Igalia)]

Attachment: Bug 1856942: part 3) Factor potentially deferring loading the sheet out of `Loader::LoadSheet`. r=emilio

Depends on D190045

Comment 4

[Mirko Brodesser (:mbrodesser-Igalia)]

Attachment: Bug 1856942: part 4) Factor potentially coalescing the load out of `Loader::LoadSheet`. r=emilio

Depends on D190046

Comment 5

[Mirko Brodesser (:mbrodesser-Igalia)]

Attachment: Bug 1856942: part 5) Factor async loading of a sheet out of `Loader::LoadSheet`. r=emilio

Depends on D190047

Comment 6

[Mirko Brodesser (:mbrodesser-Igalia)]

Attachment: Bug 1856942: part 6) Rename `DecrementOngoingLoadCount` to `DecrementOngoingLoadCountAndMaybeUnblockOnload`. r=emilio

Complements part 1.

Depends on D190048

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3e65c2025149
part 1) Rename `IncrementOngoingLoadCount` to `IncrementOngoingLoadCountAndMaybeBlockOnload`. r=emilio
https://hg.mozilla.org/integration/autoland/rev/4a5608f7276f
part 2) Factor sync loading of sheet out of `Loader::LoadSheet`. r=emilio
https://hg.mozilla.org/integration/autoland/rev/e39a99b0de3b
part 3) Factor potentially deferring loading the sheet out of `Loader::LoadSheet`. r=emilio
https://hg.mozilla.org/integration/autoland/rev/8d4df1077b73
part 4) Factor potentially coalescing the load out of `Loader::LoadSheet`. r=emilio
https://hg.mozilla.org/integration/autoland/rev/3e709d5597d9
part 5) Factor async loading of a sheet out of `Loader::LoadSheet`. r=emilio
https://hg.mozilla.org/integration/autoland/rev/a65427b65793
part 6) Rename `DecrementOngoingLoadCount` to `DecrementOngoingLoadCountAndMaybeUnblockOnload`. r=emilio

Comment 8

[Cristina Horotan [:chorotan]]

https://hg.mozilla.org/mozilla-central/rev/3e65c2025149
https://hg.mozilla.org/mozilla-central/rev/4a5608f7276f
https://hg.mozilla.org/mozilla-central/rev/e39a99b0de3b
https://hg.mozilla.org/mozilla-central/rev/8d4df1077b73
https://hg.mozilla.org/mozilla-central/rev/3e709d5597d9
https://hg.mozilla.org/mozilla-central/rev/a65427b65793