1857001 - Enable TrapSite-placement checking for arm32

Status: RESOLVED FIXED

(Core :: JavaScript: WebAssembly, enhancement, P2)

Description

[Julian Seward [:jseward]]

Bug 1846474 added a mechanism to detect incorrectly placed TrapSites. This
was complete for x86_{32,64} and arm64, but was incomplete and disabled for
arm32.

This patch completes and enables support for arm32. Most of the work --
instruction recognition for arm32 -- was already done in bug 1846474, so this
patch merely changes the return type of a few arm32 MacroAssembler routines
from void to FaultingCodeOffset, hence completing the required plumbing.

Comment 1

[Julian Seward [:jseward]]

Attachment: Bug 1857001 - Enable TrapSite-placement checking for arm32. r=rhunt.

Bug 1846474 added a mechanism to detect incorrectly placed TrapSites. This
was complete for x86_{32,64} and arm64, but was incomplete and disabled for
arm32.

This patch completes and enables support for arm32. Most of the work --
instruction recognition for arm32 -- was already done in bug 1846474, so this
patch merely changes the return type of a few arm32 MacroAssembler routines
from void to FaultingCodeOffset, hence completing the required plumbing.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5d20fede7a23
Enable TrapSite-placement checking for arm32.  r=rhunt.

Comment 3

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/5d20fede7a23