1857035 - Perma dom/svg/test/test_getCTM.html failure on new Ubuntu 22.04 Wayland pool

Status: RESOLVED FIXED

(Core :: SVG, defect)

Description

[Andrew Halberstadt [:ahal]]

This is happening on a new Ubuntu 22.04 Wayland enabled pool we're in the process of standing up.

Example failure log:
https://treeherder.mozilla.org/logviewer?job_id=431033473&repo=try&lineNumber=7250

[task 2023-10-02T16:29:30.532Z] 16:29:30     INFO - TEST-START | dom/svg/test/test_getCTM.html
[task 2023-10-02T16:29:30.650Z] 16:29:30     INFO - TEST-INFO | started process screentopng
[task 2023-10-02T16:29:35.896Z] 16:29:35     INFO - TEST-INFO | screentopng: exit 0
[task 2023-10-02T16:29:35.896Z] 16:29:35     INFO - Buffered messages logged at 16:29:30
[task 2023-10-02T16:29:35.896Z] 16:29:35     INFO - TEST-PASS | dom/svg/test/test_getCTM.html | buggy.getCTM().e 
[task 2023-10-02T16:29:35.896Z] 16:29:35     INFO - TEST-PASS | dom/svg/test/test_getCTM.html | buggy.getCTM().f 
[task 2023-10-02T16:29:35.896Z] 16:29:35     INFO - TEST-PASS | dom/svg/test/test_getCTM.html | transrect1.getCTM().a 
[task 2023-10-02T16:29:35.896Z] 16:29:35     INFO - TEST-PASS | dom/svg/test/test_getCTM.html | transrect1.getCTM().d 
[task 2023-10-02T16:29:35.896Z] 16:29:35     INFO - Buffered messages finished
[task 2023-10-02T16:29:35.896Z] 16:29:35     INFO - TEST-UNEXPECTED-FAIL | dom/svg/test/test_getCTM.html | padsvg1.getScreenCTM().e - got 27.000030517578125, expected 27
[task 2023-10-02T16:29:35.896Z] 16:29:35     INFO -     SimpleTest.is@SimpleTest/SimpleTest.js:509:14
[task 2023-10-02T16:29:35.896Z] 16:29:35     INFO -     runTest@dom/svg/test/test_getCTM.html:43:5
[task 2023-10-02T16:29:35.896Z] 16:29:35     INFO -     EventListener.handleEvent*@dom/svg/test/test_getCTM.html:120:8

It's unclear whether this is a result of Wayland, upgrading to Ubuntu 22.04 or hardware characteristics of the new workers. The test will be skipped on this new platform.

Comment 2

[Daniel Holbert [:dholbert]]

got 27.000030517578125, expected 27

Looks like it's just floating point precision/rounding error at some level.

We should just round to three decimal places before comparing, or something like that. We could also use isfuzzy but that's probably overkill.

Comment 3

[Daniel Holbert [:dholbert]]

Attachment: Bug 1857035 part 1: Tweak mochitest test_getCTM.html to pull out some repeated expressions into local variables. r?#svg,#layout

Comment 4

[Daniel Holbert [:dholbert]]

Attachment: Bug 1857035 part 2: Use isfuzzy to ignore float precision error in test_getCTM.html. r?#svg,#layout

Depends on D190351

Comment 5

[Daniel Holbert [:dholbert]]

Hi ahal:

(In reply to Andrew Halberstadt [:ahal] from comment #0)

The test will be skipped on this new platform.

That's no longer necessary after my patches here land. If it already had some skip annotation in-tree, I would just atomically remove it here as part of the posted patches -- but I'm not seeing any annotations for this test right now:
https://searchfox.org/mozilla-central/rev/3d0b07f5a3c7b8d9955fb8e8acaaf582b1e33bb6/dom/svg/test/mochitest.toml#86-88

So I assume the skip annotation hasn't landed yet. Could you remove the skip annotation from your local patch (or wherever it's staged)? Or let me know how best to avoid this test ending up being unnecessarily-skipped?

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c2e64e644067
part 1: Tweak mochitest test_getCTM.html to pull out some repeated expressions into local variables. r=firefox-svg-reviewers,longsonr
https://hg.mozilla.org/integration/autoland/rev/bdfdb575f9a9
part 2: Use isfuzzy to ignore float precision error in test_getCTM.html. r=firefox-svg-reviewers,longsonr

Comment 7

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/c2e64e644067
https://hg.mozilla.org/mozilla-central/rev/bdfdb575f9a9

Comment 8

[Andrew Halberstadt [:ahal]]

Ah oops, I didn't notice this needinfo and had landed it a couple days ago. I'll re-enable the test here.

Comment 9

[Andrew Halberstadt [:ahal]]

Attachment: Bug 1857035 - Re-enable dom/svg/test/test_getCTM.html on Ubuntu 22.04 Wayland pool, r?dholbert!

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a710f6c3ab82
Re-enable dom/svg/test/test_getCTM.html on Ubuntu 22.04 Wayland pool, r=dholbert

Comment 11

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/a710f6c3ab82