Closed Bug 1857121 Opened 1 year ago Closed 1 year ago

Perma Windows MinGW [tier 2] gmake[4]: *** [backend.mk:221: .deps/IA2Typelib.h.stub] Error 2

Categories

(Core :: Disability Access APIs, defect, P5)

defect

Tracking

()

RESOLVED FIXED
120 Branch
Tracking Status
firefox-esr115 --- unaffected
firefox118 --- unaffected
firefox119 --- unaffected
firefox120 --- fixed

People

(Reporter: intermittent-bug-filer, Assigned: Jamie)

References

(Regression)

Details

(Keywords: intermittent-failure, regression, Whiteboard: [stockwell disable-recommended][retriggered])

Attachments

(1 file)

Filed by: nfay [at] mozilla.com
Parsed log: https://treeherder.mozilla.org/logviewer?job_id=431390298&repo=autoland
Full log: https://firefox-ci-tc.services.mozilla.com/api/queue/v1/task/XMRGxyTIRNqKxbHzznGAAg/runs/0/artifacts/public/logs/live_backing.log


[task 2023-10-05T00:17:03.971Z] 00:17:03     INFO -  gmake[4]: Entering directory '/builds/worker/workspace/obj-build/accessible/interfaces/ia2'
[task 2023-10-05T00:17:03.971Z] 00:17:03     INFO -  accessible/interfaces/ia2/IA2Typelib.h.stub
[task 2023-10-05T00:17:03.971Z] 00:17:03     INFO -  /builds/worker/.mozbuild/srcdirs/gecko-8a5b87fe5d69/_virtualenvs/build/bin/python -m mozbuild.action.file_generate /builds/worker/checkouts/gecko/build/midl.py midl IA2Typelib.h .deps/IA2Typelib.h.pp .deps/IA2Typelib.h.stub /builds/worker/checkouts/gecko/accessible/interfaces/ia2/IA2Typelib.idl -app_config -I /builds/worker/checkouts/gecko/other-licenses/ia2
[task 2023-10-05T00:17:03.971Z] 00:17:03     INFO -  Executing: /builds/worker/fetches/clang/bin/x86_64-w64-mingw32-widl --win64 -m64 -app_config -I ../../../../../checkouts/gecko/other-licenses/ia2 -Oicf ../../../../../checkouts/gecko/accessible/interfaces/ia2/IA2Typelib.idl
[task 2023-10-05T00:17:03.971Z] 00:17:03     INFO -  error: interface IAccessible2_3 is referenced but not defined
[task 2023-10-05T00:17:03.971Z] 00:17:03    ERROR -  gmake[4]: *** [backend.mk:221: .deps/IA2Typelib.h.stub] Error 2
[task 2023-10-05T00:17:03.971Z] 00:17:03     INFO -  gmake[4]: Leaving directory '/builds/worker/workspace/obj-build/accessible/interfaces/ia2'
[task 2023-10-05T00:17:03.971Z] 00:17:03     INFO -  gmake[4]: Target 'export' not remade because of errors.
[task 2023-10-05T00:17:03.974Z] 00:17:03     INFO -  gmake[4]: Entering directory '/builds/worker/workspace/obj-build/accessible/interfaces/ia2'
[task 2023-10-05T00:17:03.975Z] 00:17:03     INFO -  ../../../config/nsinstall -R -m 644 'AccessibleEventId.h' '../../../dist/include'
[task 2023-10-05T00:17:03.975Z] 00:17:03     INFO -  gmake[4]: Leaving directory '/builds/worker/workspace/obj-build/accessible/interfaces/ia2'

I'm surprised midl didn't complain about this. IA2TypeLibrary.idl references IAccessible2_3, but that interface has been deprecated and is thus no longer included.

IAccessible2_3 has been removed from the merged IDL build script in the official IA2 repository. Therefore, I think the correct fix is to remove it from IA2TypeLibrary.idl as well.

Tasks:

  1. Submit a pull request to https://github.com/LinuxA11y/IAccessible2 which removes this line.
  2. Once that's merged, submit a patch to mozilla-central to update that file in other-licenses/ia2.
Assignee: nobody → jteh

Set release status flags based on info from the regressing bug 1852190

Whiteboard: [stockwell disable-recommended] → [stockwell disable-recommended][retriggered]

Most importantly, this removes the reference to the IAccessible2_3 interface, which is now deprecated and thus missing from the IDL we build in accessible/interfaces/ia2/IA2Typelib.idl.
This was causing MinGW builds to fail, though strangely, Microsoft's midl tool doesn't seem to care.

Pushed by jteh@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/9429fe765c7c Update IA2TypeLibrary.idl to latest revision (IAccessible2 repo commit 4461630f). r=morgan
Status: NEW → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED
Target Milestone: --- → 120 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: