1857152 - The cancel download button does not have a hover effect on mouse over with dark system theme

Status: VERIFIED FIXED

(Firefox :: Theme, defect)

Description

[Alexandru Trif, Desktop Test Engineering [:atrif]]

Attachment: download_hover.gif

Found in

• 119.0b5

Affected versions

• 120.0a1 (2023-10-04)
• 119.0b5

Tested platforms

• Affected platforms: macOS 12, macOS 13 ARM, Windows 10x64
• Unaffected platforms: Ubuntu 22.1

Preconditions

• system theme set to dark
• Firefox theme set to auto

Steps to reproduce

1. Start a random download.
2. Hover over the Cancel download button.

Expected result

• Hover effect is displayed.

Actual result

• No hover effect is displayed.

Regression

• Last good revision: f95c18989fd2d01b7228b5205f6851ec48fe7d42
  First bad revision: 37a26c9f2c5ced491362e75d2133695fb55d862d
  Pushlog:
  https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=f95c18989fd2d01b7228b5205f6851ec48fe7d42&tochange=37a26c9f2c5ced491362e75d2133695fb55d862d

Additional notes

• Attached a screen recording.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

:emilio, since you are the author of the regressor, bug 1843044, could you take a look?

For more information, please visit BugBot documentation.

Comment 2

[Emilio Cobos Álvarez [:emilio]]

Attachment: Bug 1857152 - Override panel-item-{hover,active}-bgcolor in browser-custom-colors. r=dao

To match https://searchfox.org/mozilla-central/rev/d436104fc6c31677b08a851796bead25153be699/browser/themes/addons/dark/manifest.json#61,63

Use button-{hover,active}-bgcolor for the light theme, which is the
default behavior.

Comment 3

[Emilio Cobos Álvarez [:emilio]]

Comment on attachment 9356821 [details]
Bug 1857152 - Override panel-item-{hover,active}-bgcolor in browser-custom-colors. r=dao

Beta/Release Uplift Approval Request

• User impact if declined: comment 0
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: comment 0
• List of other uplifts needed: none
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Simple CSS fix to match old behavior.
• String changes made/needed: none
• Is Android affected?: No

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/177823430f64
Override panel-item-{hover,active}-bgcolor in browser-custom-colors. r=dao,desktop-theme-reviewers

Comment 5

[Cristina Horotan [:chorotan]]

https://hg.mozilla.org/mozilla-central/rev/177823430f64

Comment 6

[Giorgia Nichita, Release Desktop QA]

Reproduced this issue on an affected Nightly build on macOS 11. The hove effect of the cancel download button is missing.
Verified as fixed on Firefox 120.0a1 (20231005212657) using macOS 11 and Windows 10.

Comment 7

[Donal Meehan [:dmeehan]]

Comment on attachment 9356821 [details]
Bug 1857152 - Override panel-item-{hover,active}-bgcolor in browser-custom-colors. r=dao

Approved for 119.0b7

Comment 8

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-beta/rev/ce4a811f95e1

Comment 9

[Giorgia Nichita, Release Desktop QA]

Verified as fixed on Firefox 119.0b7 (treeherder build - 20231006183527) using macOS 11 and Windows 10.