1857155 - Simplify FileSystemWritableFileStream construction

Status: RESOLVED FIXED

(Core :: DOM: File, task, P1)

Description

[Jan Varga [:janv]]

FileSystemWritableFileStream::Create is currently async and thus quite complicated. The only reason why the method is async is that we deserialize the stream immediately. FileSystemSyncAccessHandle does it lazily, so the construction is less complicated. I think we should try to align FileSystemWritableFileStream::Create and FileSystemSyncAccessHandle::Create which should make is easier to fix any remaining bugs in the construction code.

Comment 1

[Jan Varga [:janv]]

Attachment: Bug 1857155 - Move WriteImpl to FileSystemWritableFileStream; r=#dom-storage

Comment 2

[Jan Varga [:janv]]

Attachment: Bug 1857155 - Make sure FileSystemWritableFileStream can't go away during Seek, Truncate and Close/Abort; r=#dom-storage

Depends on D190163

Comment 3

[Jan Varga [:janv]]

Attachment: Bug 1857155 - Deserialize stream for FileSystemWritableFileStream lazily; r=#dom-storage

Depends on D190168

Comment 4

[Jan Varga [:janv]]

Attachment: Bug 1857155 - Change FileSystemWritableFileStream::Create to return constructed streams synchronously; r=#dom-storage

Depends on D190172

Comment 5

[Jan Varga [:janv]]

Attachment: Bug 1857155 - Remove redundant build worker ref; r=#dom-storage

Depends on D190173

Comment 6

[Jan Varga [:janv]]

Attachment: Bug 1857155 - Remove custom ResolveCallback for FileSystemGetWritableFileStreamResponse; r=#dom-storage

Depends on D190175

Comment 7

[Jan Varga [:janv]]

https://treeherder.mozilla.org/jobs?repo=try&revision=9212d8758f1d67e1cea0794f2e37a76f7dab1192

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6b0cfa844626
Move WriteImpl to FileSystemWritableFileStream; r=dom-storage-reviewers,aiunusov,jari
https://hg.mozilla.org/integration/autoland/rev/46d5fe8826c9
Make sure FileSystemWritableFileStream can't go away during Seek, Truncate and Close/Abort; r=dom-storage-reviewers,jari
https://hg.mozilla.org/integration/autoland/rev/52c54e9b898b
Deserialize stream for FileSystemWritableFileStream lazily; r=dom-storage-reviewers,jari
https://hg.mozilla.org/integration/autoland/rev/3bc476959474
Change FileSystemWritableFileStream::Create to return constructed streams synchronously; r=dom-storage-reviewers,jari
https://hg.mozilla.org/integration/autoland/rev/f49baa5f51c6
Remove redundant build worker ref; r=dom-storage-reviewers,asuth
https://hg.mozilla.org/integration/autoland/rev/3d1ac3fb7670
Remove custom ResolveCallback for FileSystemGetWritableFileStreamResponse; r=dom-storage-reviewers,jari

Comment 9

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/6b0cfa844626
https://hg.mozilla.org/mozilla-central/rev/46d5fe8826c9
https://hg.mozilla.org/mozilla-central/rev/52c54e9b898b
https://hg.mozilla.org/mozilla-central/rev/3bc476959474
https://hg.mozilla.org/mozilla-central/rev/f49baa5f51c6
https://hg.mozilla.org/mozilla-central/rev/3d1ac3fb7670