1857185 - Collabora Online spreadsheet shows uneven lines, specially noticeable on dark mode

Status: RESOLVED DUPLICATE of bug 1933668

(Core :: Graphics: Canvas2D, defect)

Description

[Timur]

Attachment: Grid.png

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:109.0) Gecko/20100101 Firefox/115.0

Steps to reproduce:

We are using Collabora Online with spreasheet in a browser.
In recent Firefox, like 115, grid does not look good.

Actual results:

Grid is darker, thicker lines with white background, and it every couple of rows the grid gets dimmer, especia;;y visible in dark background.

Expected results:

Grid is thin and crisp as it was.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

The Bugbug bot thinks this bug should belong to the 'Core::Layout: Grid' component, and is moving the bug to that component. Please correct in case you think the bot is wrong.

Comment 2

[Timur]

Attachment: Grid-dark.png

Grid dark

Comment 3

[Emilio Cobos Álvarez (:emilio)]

Can you share a URL where this happens? I didn't find a free demo page or something. I tried to request a demo account to collabora but it's not instant :)

This is probably in the wrong component (more likely to be a canvas issue of sorts). Some questions:

• Can you attach your about:support information?
• Lacking a way to reproduce, would you be able to look for a regression range using mozregression? Something like this if you're on Linux:

$ pip3 install --user mozregression
$ MOZ_DISABLE_CONTENT_SANDBOX=1 mozregression --good 102 --bad 115 -a <url>

Assuming Firefox 102 works fine for you. That'd pin point when it started which would be immensely useful. Thanks.

Comment 4

[Timur]

Online demo should be available from https://www.collaboraoffice.com/collabora-online/.
Here is a link to spreadsheet https://staging.eu.collaboraonline.com/nextcloud/index.php/s/4p7ybEntkF866Nj pass is CO123
Please also try View-Dark mode.

Please try. I may send about:support but that should not be needed, we all se this issue and is also reported at https://github.com/CollaboraOnline/online/issues/7316.

I will try mozregression. Thanks.

Comment 5

[Timur]

Last good revision: b6075e0dc768ad48e54aba5e8bc5ce8499a30341
First bad revision: a3eb3df78c8bb32dcaff0fab5674c777c7ba04ef
Pushlog:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=b6075e0dc768ad48e54aba5e8bc5ce8499a30341&tochange=a3eb3df78c8bb32dcaff0fab5674c777c7ba04ef

Comment 6

[Emilio Cobos Álvarez (:emilio)]

Thanks, that's awesome. I can repro with the link in comment 4 (and the spreadsheet is indeed a 2d canvas). Moving to the relevant component.

Comment 7

[Timur]

Now that you provided such a fine bisect tool, I found also a previous regression in Firefox 109, with thicker lines in the upper part of Calc sheet, seen well in dark mode. Hopefully this is the commit.

Last good revision: 6a4feb11b8f72137f1ea38cb489d433bd52724ff
First bad revision: c1d54f41f9841220b2b469ab1590804090d2e16a
Pushlog:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=6a4feb11b8f72137f1ea38cb489d433bd52724ff&tochange=c1d54f41f9841220b2b469ab1590804090d2e16a

Comment 8

[Emilio Cobos Álvarez (:emilio)]

Can you file that one separately? It might have the same underlying issue as this one or it might not, so better to track in a different bug :)

Comment 9

[Timur]

Attachment: Grid-dark-109.png

Grid dark upper part NOK from 109.

Comment 10

[Timur]

I may file, but I would rather see what will happen here. If not resolved, I will file, now it is clear. Thanks.

Comment 11

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1834079

:lsalzman, since you are the author of the regressor, bug 1834079, could you take a look? Also, could you set the severity field?

For more information, please visit BugBot documentation.

Comment 12

[Donal Meehan [:dmeehan]]

:bhood we are in the final week of beta for Fx119 - does this have a priority for a fix soon or will it be in a later release.

Comment 13

[Bob Hood [:bhood]]

Right now, Lee is working on off-main-thread Canvas support for Speedometer 3, and that's his highest priority until it lands. Tim, do you think this is something you could handle?

Comment 14

[Timothy Nikkel (:tnikkel)]

I'll take a look. (leaving needinfo)

Comment 15

[Timothy Nikkel (:tnikkel)]

I am using canvas-rr to get a recording of this to hopefully produce a small reproducible testcase. canvas-rr seems to be needed to be extended to support serializing and de-serializing ImageData objects, started working on that.

Comment 16

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1834079

Comment 17

[Timothy Nikkel (:tnikkel)]

Bug 1867194 is a similar looking bug that is regressed by the same bug, but it's testcase is much simply. Might be easier to debug that.

Comment 18

[Timur]

There is another non-cosmetic aspect of this: when cells are merged, they do not appear so, whcih confuses users of Collabora Online.