1857221 - Consider to disable column tracking when doing fragment parsing

Status: RESOLVED FIXED

(Core :: DOM: HTML Parser, enhancement)

Description

[Olli Pettay [:smaug][[e-mail]]]

https://searchfox.org/mozilla-central/rev/d436104fc6c31677b08a851796bead25153be699/parser/html/nsHtml5TokenizerHSupplement.h#13 shows up in the performance profiles quite a bit these days when doing innerHTML parsing.

Comment 1

[Olli Pettay [:smaug][[e-mail]]]

https://treeherder.mozilla.org/perfherder/comparesubtest?originalProject=try&newProject=try&newRevision=88029ff6eb371c739224c98748b1d6ff1c178e48&originalSignature=4586009&newSignature=4586009&framework=13&application=firefox&originalRevision=e32000ca073e5f7b3e9b5e184feab19fb1c6fe40&page=1&showOnlyConfident=1 shows significant improvements in innerHTML heavy jQuery and ES6 tests, both improving over 2%.

Need to figure out when and how we can disable column tracking.

Comment 2

[Henri Sivonen (:hsivonen) (temporarily away from Bugzilla)]

Attachment: Bug 1857221 - Avoid tracking the line and column number when parsing innerHTML.

Comment 3

[Henri Sivonen (:hsivonen) (temporarily away from Bugzilla)]

https://treeherder.mozilla.org/jobs?repo=try&revision=ae3f77c35ccc77d9b8fe11e484ee1e7532cca641

Comment 4

[Henri Sivonen (:hsivonen) (temporarily away from Bugzilla)]

Turn off line and column for DOMParser as well:
https://treeherder.mozilla.org/jobs?repo=try&revision=f4eddde2213466a0a899846c98dd2d71ff603ca4

Comment 5

[Henri Sivonen (:hsivonen) (temporarily away from Bugzilla)]

https://treeherder.mozilla.org/jobs?repo=try&revision=3e25698fb107c99eb263c0178287ff0e55cded13

Comment 6

[Henri Sivonen (:hsivonen) (temporarily away from Bugzilla)]

https://github.com/validator/htmlparser/commit/756e6ff41ce117455e5c4e713fafc27d05823cfb

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e8b9e675ddde
Avoid tracking the line and column number when parsing innerHTML. r=smaug

Comment 8

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/e8b9e675ddde