1857244 - Netmonitor offline mode is only reset when setting `No throttling`

Status: VERIFIED FIXED

(DevTools :: Netmonitor, defect, P2)

Description

[Valentin Gosu [:valentin] (he/him)]

1. Open tab
2. set offline throttling mode in the netmonitor
3. open http://example.com (Should display OFFLINE error page)
4. Set GPRS throttling profile in netmonitor
5. Refresh the page (Page should load, but instead still displays offline error page)

Comment 1

[Julian Descottes [:jdescottes]]

Thanks for the STRs, bug for a new feature should be fixed rapidly.

Comment 2

[Hubert Boma Manilla (:bomsy)]

Attachment: Bug 1857244 - [devtools] Reset netmonitor offline when throttling mode is changed r=#devtools-reviewers

Comment 3

[BugBot [:suhaib / :marco/ :calixte]]

There is an r+ patch which didn't land and no activity in this bug for 2 weeks.
:bomsy, could you have a look please?
If you still have some work to do, you can add an action "Plan Changes" in Phabricator.
For more information, please visit BugBot documentation.

Comment 4

[Hubert Boma Manilla (:bomsy)]

We need to land this fix with a test (which is in Bug 1855129). I'll get back to finishing the test in a few.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/78c127f4a596
[devtools] Reset netmonitor offline when throttling  mode is changed r=devtools-reviewers,jdescottes

Comment 6

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/78c127f4a596

Comment 7

[Giorgia Nichita, Release Desktop QA]

Reproduced this issue on an affected nightly build from 2023-10-05 on Win 10.
Verified as fixed on Firefox 121.0b4 (20231127091758) and 122.0a1 (20231129050021) on Ubuntu 22, macOS 11 and Windows 10.