1857304 - [wpt-sync] Sync PR 42368 - Fallback-url-to-local.html passes in an unintended way.

Status: RESOLVED FIXED

(Core :: Layout: Text and Fonts, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 42368 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/42368
Details from upstream follow.

ChangSeok Oh <[e-mail]> wrote:

Fallback-url-to-local.html passes in an unintended way.

I found Blink passed the fallback-url-to-local.html test in an
unexpected way while investigating issue 1416842 [1]. It passes the test
by returning false at the end of FontFaceSet::check() instead of doing
false due to the failure of CheckFont() [2] above. This is because the
remote-font in the test is never resolved due to a parsing error caused
by the query part of the font-face src address. We can fix it by
stringifying the address and make Gecko and WebKit happy with the
assert_false test.

[1] https://crbug.com/1416842
[2] https://source.chromium.org/chromium/chromium/src/+/main:third_party/blink/renderer/core/css/font_face_set.cc;drc=9ed4a90ee6aeaa3c1911d229dec6317d8fe8260d;l=251

Test: external/wpt/css/css-fonts/fallback-url-to-local.html

Bug: 1416842
Change-Id: Id158ec75273518929c8967a5b1e157f04d48dd81

Reviewed-on: https://chromium-review.googlesource.com/4917071
WPT-Export-Revision: 76c4569b9e7484ce35e2fc94966933a9a642706b

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=f3eb5a21fdbc87bfeea0824bab11fc3a7d9f8a4e

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0ef6398a0783
[wpt PR 42368] - Fallback-url-to-local.html passes in an unintended way., a=testonly

Comment 3

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Test result changes from PR not available.

Comment 4

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/0ef6398a0783