Closed Bug 1857339 Opened 2 years ago Closed 2 years ago

[wpt-sync] Sync PR 42232 - Make navigation-api/ tests resilient to starting with extra NavigationHistoryEntries

Tracking

(firefox121 fixed)

Status:

RESOLVED FIXED

Milestone:

121 Branch

Tracking Flags:

Tracking

Status

firefox121

---

fixed

People

(Reporter: wpt-sync, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)

Assignee

Description

•

2 years ago

Sync web-platform-tests PR 42232 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/42232
Details from upstream follow.

Nate Chapin <japhet@chromium.org> wrote:

Make navigation-api/ tests resilient to starting with extra NavigationHistoryEntries

When WPT are run in-browser or via wptrunner, there may be additional
session history entries when the test starts, so the tests shouldn't
assume that they start with navigation.entries().length == 1 or
navigation.currentEntry.index == 0.

This fixes all directories except navigate-event/ and
navigation-methods/, which had enough tests to deserve separate
treatment.

This is a workaround for https://github.com/web-platform-tests/wpt/issues/33590.

Change-Id: Ic60de8ffe247b374ef3a0e0939fc4c1a3427c7e7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4903245
Auto-Submit: Nate Chapin \<japhet@chromium.org>
Commit-Queue: Nate Chapin \<japhet@chromium.org>
Reviewed-by: Domenic Denicola \<domenic@chromium.org>
Reviewed-by: Weizhong Xia \<weizhong@google.com>
Cr-Commit-Position: refs/heads/main@{#1204873}

Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)

Assignee

Comment 1

•

2 years ago

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=44ec469862e9abe13e8e63fc9136349973a3d281

Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)

Assignee

Comment 2

•

2 years ago

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=d9e671a69ebf56c343e09ed60caded4845b1c008

Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)

Assignee

Comment 3

•

2 years ago

CI Results

Ran 9 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 31 tests and 1 subtests

Status Summary

Firefox

OK : 25[Gecko-linux1804-64-qr-opt, Gecko-windows11-32-2009-qr-debug, Gecko-windows11-32-2009-qr-opt, Gecko-windows11-64-2009-qr-debug, Gecko-windows11-64-2009-qr-opt] 26[Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-qr-debug] 27[GitHub]
FAIL : 26[Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows11-32-2009-qr-debug, Gecko-windows11-32-2009-qr-opt, Gecko-windows11-64-2009-qr-debug, Gecko-windows11-64-2009-qr-opt] 27[GitHub]
TIMEOUT: 3
ERROR : 4[Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-qr-debug, GitHub] 5[Gecko-linux1804-64-qr-opt, Gecko-windows11-32-2009-qr-debug, Gecko-windows11-32-2009-qr-opt, Gecko-windows11-64-2009-qr-debug, Gecko-windows11-64-2009-qr-opt]

Chrome

OK : 31
PASS : 34

Safari

OK : 26
FAIL : 27
TIMEOUT: 3
ERROR : 5

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

/navigation-api/navigation-history-entry/key-id-back-cross-document.html [wpt.fyi]: OK [GitHub], SKIP [Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows11-32-2009-qr-debug, Gecko-windows11-32-2009-qr-opt, Gecko-windows11-64-2009-qr-debug, Gecko-windows11-64-2009-qr-opt] (Chrome: OK, Safari: OK)
- NavigationHistoryEntry's key and id on cross-document back navigation: FAIL (Chrome: PASS, Safari: FAIL)
/navigation-api/commit-behavior/after-transition-traverse.html [wpt.fyi]: ERROR (Chrome: OK, Safari: ERROR)
/navigation-api/currententrychange-event/anchor-click.html [wpt.fyi]
- currententrychange fires for link click: FAIL (Chrome: PASS, Safari: FAIL)
/navigation-api/currententrychange-event/history-back-same-doc.html [wpt.fyi]
- currententrychange fires for history.back(): FAIL (Chrome: PASS, Safari: FAIL)
/navigation-api/currententrychange-event/history-pushState.html [wpt.fyi]
- currententrychange fires for history.pushState(): FAIL (Chrome: PASS, Safari: FAIL)
/navigation-api/currententrychange-event/history-replaceState.html [wpt.fyi]
- currententrychange fires for history.replaceState(): FAIL (Chrome: PASS, Safari: FAIL)
/navigation-api/currententrychange-event/location-api.html [wpt.fyi]
- currententrychange fires for location API navigations: FAIL (Chrome: PASS, Safari: FAIL)
/navigation-api/currententrychange-event/navigation-back-forward-same-doc.html [wpt.fyi]
- currententrychange fires for same-document navigation.back() and navigation.forward(): FAIL (Chrome: PASS, Safari: FAIL)
/navigation-api/currententrychange-event/navigation-navigate-replace-same-doc.html [wpt.fyi]
- currententrychange fires for navigation.navigate() with replace: FAIL (Chrome: PASS, Safari: FAIL)
/navigation-api/currententrychange-event/navigation-navigate-same-doc.html [wpt.fyi]
- currententrychange fires for navigation.navigate(): FAIL (Chrome: PASS, Safari: FAIL)
/navigation-api/navigation-history-entry/current-basic.html [wpt.fyi]
- Basic tests for navigation.currentEntry: FAIL (Chrome: PASS, Safari: FAIL)
/navigation-api/navigation-history-entry/entries-after-navigations-in-multiple-windows.html [wpt.fyi]
- navigation.entries() behavior when multiple windows navigate.: FAIL (Chrome: PASS, Safari: FAIL)
/navigation-api/navigation-history-entry/entries-when-inactive.html [wpt.fyi]
- A non-active entry in navigation.entries() should not be modified when a different entry is modified: FAIL (Chrome: PASS, Safari: FAIL)
/navigation-api/navigation-history-entry/index-not-in-entries.html [wpt.fyi]
- entry.index should return -1 when not in navigation.entries(): FAIL (Chrome: PASS, Safari: FAIL)
/navigation-api/navigation-history-entry/key-id-back-same-document.html [wpt.fyi]
- NavigationHistoryEntry's key and id on same-document back navigation: FAIL (Chrome: PASS, Safari: FAIL)
/navigation-api/navigation-history-entry/key-id-location-reload.html [wpt.fyi]
- NavigationHistoryEntry's key and id after location.reload(): FAIL (Chrome: PASS, Safari: FAIL)
/navigation-api/navigation-history-entry/key-id-location-replace.html [wpt.fyi]
- NavigationHistoryEntry's key and id after location.replace(): FAIL (Chrome: PASS, Safari: FAIL)
/navigation-api/navigation-history-entry/sameDocument-after-fragment-navigate.html [wpt.fyi]
- entry.sameDocument after same-document navigations: FAIL (Chrome: PASS, Safari: FAIL)
/navigation-api/ordering-and-transition/currententrychange-before-popstate-intercept.html [wpt.fyi]
- currententrychange fires before popstate for navigation.back() and navigation.forward(): FAIL (Chrome: PASS, Safari: FAIL)
/navigation-api/ordering-and-transition/currententrychange-dispose-ordering.html [wpt.fyi]
- Ordering between Navigation currententrychange and NavigationHistoryEntry dispose events: FAIL (Chrome: PASS, Safari: FAIL)
/navigation-api/per-entry-events/dispose-for-full-session-history.tentative.html [wpt.fyi]: ERROR [Gecko-linux1804-64-qr-opt, Gecko-windows11-32-2009-qr-debug, Gecko-windows11-32-2009-qr-opt, Gecko-windows11-64-2009-qr-debug, Gecko-windows11-64-2009-qr-opt], OK [Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-qr-debug, GitHub] (Chrome: OK, Safari: ERROR)
- Dispose should fire when an entry is removed from session history due to too many entries: FAIL (Chrome: PASS, Safari: FAIL)
/navigation-api/per-entry-events/dispose-for-navigation-in-child.html [wpt.fyi]
- Dispose events should fire when entries are removed by a navigation in a different frame: FAIL (Chrome: PASS, Safari: FAIL)
/navigation-api/per-entry-events/dispose-same-document-intercept.html [wpt.fyi]
- dispose events when forward-pruning same-document entries: FAIL (Chrome: PASS, Safari: FAIL)
/navigation-api/per-entry-events/dispose-same-document-navigate-during.html [wpt.fyi]
- navigate() during a same-document-navigation-initiated dispose works (since it's after the previous navigation): FAIL (Chrome: PASS, Safari: FAIL)
/navigation-api/per-entry-events/dispose-same-document-replace-with-intercept.html [wpt.fyi]
- dispose events when doing a same-document replace using navigation.navigate() and intercept(): FAIL (Chrome: PASS, Safari: FAIL)
/navigation-api/per-entry-events/dispose-same-document-replaceState.html [wpt.fyi]
- dispose events when doing a same-document replace using history.replaceState(): FAIL (Chrome: PASS, Safari: FAIL)
/navigation-api/per-entry-events/dispose-same-document.html [wpt.fyi]
- dispose events when forward-pruning same-document entries: FAIL (Chrome: PASS, Safari: FAIL)
/navigation-api/per-entry-events/dispose-skip-current-on-truncate.html [wpt.fyi]
- Removing a currentEntry from the joint session history shouldn't dispose it: FAIL (Chrome: PASS, Safari: FAIL)
/navigation-api/state/same-document-away-and-back-location-api.html [wpt.fyi]: ERROR (Chrome: OK, Safari: ERROR)
- entry.getState() behavior after navigating away using a fragment change, then back: TIMEOUT (Chrome: PASS, Safari: TIMEOUT)
/navigation-api/state/same-document-away-and-back-navigation-api.html [wpt.fyi]: ERROR (Chrome: OK, Safari: ERROR)
- entry.getState() behavior after navigating away using the navigation API, then back: TIMEOUT (Chrome: PASS, Safari: TIMEOUT)
/navigation-api/updateCurrentEntry-method/same-document-away-and-back-location-api.html [wpt.fyi]: ERROR (Chrome: OK, Safari: ERROR)
- entry.getState() behavior after navigating away using the location API, then back: TIMEOUT (Chrome: PASS, Safari: TIMEOUT)

Tests Disabled in Gecko Infrastructure

/navigation-api/navigation-history-entry/key-id-back-cross-document.html [wpt.fyi]: OK [GitHub], SKIP [Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows11-32-2009-qr-debug, Gecko-windows11-32-2009-qr-opt, Gecko-windows11-64-2009-qr-debug, Gecko-windows11-64-2009-qr-opt] (Chrome: OK, Safari: OK)

Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)

Assignee

Updated

•

2 years ago

Depends on: 1859716

Pulsebot

Comment 4

•

2 years ago

Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/4bba353a6fc4 [wpt PR 42232] - Make navigation-api/ tests resilient to starting with extra NavigationHistoryEntries, a=testonly https://hg.mozilla.org/integration/autoland/rev/ec4774737580 [wpt PR 42232] - Update wpt metadata, a=testonly

Cosmin Sabou [:CosminS]

Comment 5

•

2 years ago

bugherder

https://hg.mozilla.org/mozilla-central/rev/4bba353a6fc4
https://hg.mozilla.org/mozilla-central/rev/ec4774737580

Status: NEW → RESOLVED

Closed: 2 years ago

status-firefox121: --- → fixed

Resolution: --- → FIXED

Target Milestone: --- → 121 Branch

You need to log in before you can comment on or make changes to this bug.

Bugzilla

[wpt-sync] Sync PR 42232 - Make navigation-api/ tests resilient to starting with extra NavigationHistoryEntries

Categories

(Testing :: web-platform-tests, task, P4)

Tracking

(firefox121 fixed)

People

(Reporter: wpt-sync, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Crash Data

Security

(public)

User Story

Description

Comment 1

Comment 2

Comment 3

CI Results

Status Summary

Firefox

Chrome

Safari

Links

Details

New Tests That Don't Pass

Tests Disabled in Gecko Infrastructure

Updated

Comment 4

Comment 5