1857431 - Use xpc::InitGlobalObjectOptions more

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, task)

Description

[Tom Schuster]

We already use xpc::InitGlobalObjectOptions in two places to set-up some common RealmOption options. However we have a lot more places that create realms (globals) that could probably benefit from using this shared helper.

I don't really like having all these boolean parameters, but I don't have a good solution for it right now. One partial idea I had was to pass the ShouldResistFingerprinting function as a pointer to reduce the amount of code duplication and number of parameters?

Comment 1

[Tom Schuster]

Attachment: Bug 1857431 - Add aSecureContext to xpc::InitGlobalObjectOptions. r?mccr8,smaug

Comment 2

[Tom Schuster]

Attachment: Bug 1857431 - Use xpc::InitGlobalObjectOptions for Workers. r?#dom-workers-and-storage-reviewers

This introduces two slight changes of behavior:

• Workers with a system principal are now always treated as secure context, without looking at the mIsSecureContext flag.
• We now also discard sources for all types of workers with a system principal

Depends on D190281

Comment 3

[Tom Schuster]

Attachment: Bug 1857431 - Move InitGlobalObjectOptions to xpcpublic.h. r?mccr8

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a123f5f76df9
Move InitGlobalObjectOptions to xpcpublic.h. r=mccr8
https://hg.mozilla.org/integration/autoland/rev/851710cba0db
Add aSecureContext to xpc::InitGlobalObjectOptions. r=mccr8,smaug
https://hg.mozilla.org/integration/autoland/rev/71a693e4a4d9
Use xpc::InitGlobalObjectOptions for Workers. r=dom-worker-reviewers,smaug
https://hg.mozilla.org/integration/autoland/rev/99a4d6fcfc2f
apply code formatting via Lando

Comment 5

[Cristina Horotan [:chorotan]]

https://hg.mozilla.org/mozilla-central/rev/a123f5f76df9
https://hg.mozilla.org/mozilla-central/rev/851710cba0db
https://hg.mozilla.org/mozilla-central/rev/71a693e4a4d9
https://hg.mozilla.org/mozilla-central/rev/99a4d6fcfc2f