1857533 - [a11y] Disclosure buttons are missing expanded/collapsed states on Review Checker

Status: RESOLVED FIXED

(Fenix :: Shopping, defect, P2)

Description

[Anna Yeddi [:ayeddi]]

Attachment: no-state-is-announced-on-collapse-expand.png

STR:

1. Ensure a TalkBack is running
2. Navigate to any Amazon product page and activate the Review Checker
3. Navigate to How we determine review quality and listen to the screen reader's announcement
   1. Confirm the control is collapsed
4. Double-tap to activate this control and observe the TB announcement
   1. Confirm the control is now expanded
5. Repeat the above steps for Settings button

Expected:

1. The button is announced as collapsed, when focused with TB (i.e. How we determine review quality, Expanded, button, double tap to activate or How we determine review quality, Button, Double-tap to Expand, depending on the implementation)
2. When activated, the button is announced as expanded (i.e. Expanded only, without repeating the label and role, example: Play Store > app page > "App support V" control state change announcement)

Actual:

1. No state is announced
2. no change is communicated

Device: Samsung Galaxy A54 running Androd 13 (One UI 5.1)

Comment 3

[BMO Github Automation]

Attachment: [mozilla-mobile/firefox-android] Bug 1857533 - [a11y] Fakespot add missing expanded/collapsed states (#4221)

Comment 4

[BMO Github Automation]

Authored by https://github.com/DreVla
https://github.com/mozilla-mobile/firefox-android/commit/bd53d474d229629e111d5e1ccfefb93501bfad91
[main] Bug 1857533 - [a11y] Fakespot add missing expanded/collapsed states

Comment 5

[Chris Peterson [:cpeterson]]

Vlad, should we uplift this fix to Beta 120? We normally don't uplift fixes that add new strings, but we don't need to translated strings for the Review Checker launch in 120.

Comment 6

[miralobontiu]

Verified as fixed on the Fenix Nightly 121.0a1 from 10/31 with Lenovo tab M10 (Android 10).
When the user reaches the How we determine review quality section, talkback announces: "How we determine review quality? Collapsed. Double-tap to expand.". When the section is expanded, it announces: "Expanded"

Comment 7

[Vlad Dreghici [:vdreghici]]

(In reply to Chris Peterson [:cpeterson] from comment #5)

Vlad, should we uplift this fix to Beta 120? We normally don't uplift fixes that add new strings, but we don't need to translated strings for the Review Checker launch in 120.

After discussing with Rahul, we have decided to let this ride the train since there are many changes on the UI side for ads and they might conflict.

Comment 8

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:vdreghici, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
• If no, please set status-firefox120 to wontfix.

For more information, please visit BugBot documentation.

Comment 9

[Chris Peterson [:cpeterson]]

Thanks. In that case, I will set the status-firefox120 flag to wontfix.