1857537 - [a11y] Review Checker is missing a heading structure

Status: VERIFIED FIXED

(Fenix :: Shopping, defect, P2)

Description

[Anna Yeddi [:ayeddi]]

STR:

1. Ensure a TalkBack is running
2. Navigate to any Amazon product page and activate the Review Checker
3. Navigate to Review Checker BETA text and listen to the screen reader's announcement
4. Using a TB shortcut, try to navigate between headings and observe the TB announcement
   1. Use 3 finger swipe left/right to switch the shortcut options to Heading and then use 1 finger swipe up/right to navigate between selected types of elements (headings)

Expected:

1. Review Checker BETA is announced as heading and can be navigated to/from with TB shortcuts.
   • Headings help users with cognitive difficulties and users with low vision who rely on a screen reader to better understand the purpose of the block of UI that they navigate to, like a title of a book.
2. A heading in the error message (i.e. No info available right now) is announced as a heading and can be navigated to/from with TB shortcuts.
3. (optional) disclosure button's labels are announced as headings and can be navigated between with TB shortcut (How we determine review quality? and Settings, example could be Play Store > app page > App Support V control)

Actual:

1. No state is announced for Review Checker BETA
2. Review Checker BETA cannot be navigated to using TB shortcuts to navigate between headings
3. Same applies to an error message heading (i.e. No info available right now) and (optional) the disclosure button's labels (i.e. Settings)

Device: Samsung Galaxy A54 running Androd 13 (One UI 5.1)

Comment 1

[Anna Yeddi [:ayeddi]]

Attachment: review-checker-title-is-an-implicit-heading-not-a-programmatic-one.png

Comment 2

[BMO Github Automation]

Attachment: [mozilla-mobile/firefox-android] Bug 1857537 - [a11y] Add heading structure to Review Checker (#4415)

Comment 3

[Rebeca Tudor]

Hi Anna!
I started to work on this ticket and I see in description you only mentioned in your 3rd point in "Expected", the expandable cards to be announced as headings (How we determine review quality? and Settings ).

I wanted to verify if it's wanted to be recognized and announced as heading the other cards too (How reliable are these reviews?, Adjusted rating, Highlights from recent reviews ) ?

Comment 4

[Rebeca Tudor]

Attachment: reviewchecker.png

Comment 5

[Anna Yeddi [:ayeddi]]

(In reply to Rebeca Tudor from comment #3)

Hi Anna!
I started to work on this ticket and I see in description you only mentioned in your 3rd point in "Expected", the expandable cards to be announced as headings (How we determine review quality? and Settings ).

I wanted to verify if it's wanted to be recognized and announced as heading the other cards too (How reliable are these reviews?, Adjusted rating, Highlights from recent reviews ) ?

Rebecca, thank you very much for following up on that and for working on the bug. Yes, that would be great!

Especially, when the longer blocks of text are expanded, having headings would provide users with opportunity to navigate between sections using TalkBack shortcuts

Comment 6

[Rebeca Tudor]

Thank you for your confirmation!

Comment 7

[BMO Github Automation]

Authored by https://github.com/RebecaTudor
https://github.com/mozilla-mobile/firefox-android/commit/575bab52ec300fe2f5a984046ac5e7b4fbc36231
[main] Bug 1857537 - [a11y] Add heading structure to Review Checker

Comment 8

[miralobontiu]

Verified on the latest Fenix Nightly 122.0a1 from 11/22 with Google Pixel 6 (Android 14).

Comment 9

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:rebecatudor273, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
• If no, please set status-firefox121 to wontfix.

For more information, please visit BugBot documentation.