1857544 - [a11y] The Review Checker sheet does not scroll into the view elements from under the OS footer when TalkBack is focusing them

Status: VERIFIED FIXED

(Fenix :: Shopping, defect, P2)

Description

[Anna Yeddi [:ayeddi]]

STR:

1. Ensure a TalkBack is running
2. Navigate to any Amazon product page (that has review checker results available) and activate the Review Checker
3. Using logical navigation (swipe left-to-right with one finger) navigate to the end of the Review Checker sheet and observe the visual TB focus position and announcement

Expected:

1. Once the TB focus is approaching the bottom of the view, the sheet view is scrolled up into the view

Actual:

1. Once the TB focus is approaching the bottom of the view, the sheet does not scroll and the TB focus continues to move down, visually being hidden under the OS footer. It results in the following:
   1. position of the screen reader focus being unknown to a user (affects TB users with vision, i.e. users with low vision or users with cognitive difficulties, dyslexia)
   2. creates a possibility for active areas being overlapped - a screen reader may send a click on one of the OS footer controls (i.e. Back or Home) while the user is double-tapping a button on a Review Checker (but since the OS footer is layered on top of that control, the click would be intercepted).

Device: Samsung Galaxy A54 running Androd 13 (One UI 5.1)

Comment 1

[Anna Yeddi [:ayeddi]]

Attachment: focus-overlaps-with-os-footer.png

Comment 2

[Anna Yeddi [:ayeddi]]

This feels like a borderline issue but likely not a blocker, thus reducing the accessibility severity to s3, but still highly encourage to prioritize the fix of this access-s3 among other access-s3 bugs

Comment 3

[BMO Github Automation]

Attachment: [mozilla-mobile/firefox-android] Bug 1857544 - [a11y]Fully expand review checker when screen reader on (#5383)

Comment 4

[miralobontiu]

Verified as fixed on the latest Fenix Nightly 125.0a1 from 2/28 with a Samsung Galaxy S24 (Android 14) device.
The review checker sheet scrolls while the user goes through it using talckback gestures.

Comment 5

[BMO Github Automation]

Authored by https://github.com/DreVla
https://github.com/mozilla-mobile/firefox-android/commit/1a66d2ff56ba3ecd04332c60e7995b9c21e541ab
[main] Bug 1857544 - [a11y]Fully expand review checker when screen reader on

Comment 6

[miralobontiu]

Verified as fixed on the latest Fenix Nightly 125.0a1 from 2/29 with a Google Pixel 6 (Android 14) device, and a Samsung Galaxy S24 (Android 14).
The review checker sheet is displayed fully expanded, and scrolls while the user goes through it using talckback gestures.

Talkback version: 14.1

Note: if I force the bottom sheet to the HALF_VIEW state, then the issue can still be noticed. This might be an edge case, but is important to remember.