1857675 - Remove pre-Lollipop code into mobile/android

Status: RESOLVED FIXED

(GeckoView :: General, task, P1)

Comment 1

[Makoto Kato [:m_kato]]

Attachment: Bug 1857675 - Remove pre-Lollipop conditions from mobile/android. r=#geckoview-reviewers!,jnicol!,jolin!

Since we have landed bug 1820295, let's remove old code.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b4504aa44a84
Remove pre-Lollipop conditions from mobile/android. r=jnicol,geckoview-reviewers,eeejay,media-playback-reviewers,aosmond,owlish

Comment 3

[Narcis Beleuzu [:NarcisB]]

Backed out for Lint failure

Backout link: https://hg.mozilla.org/integration/autoland/rev/75936f589527bc6d8c7a4e9a9a54f1cd7ca77577
Log link: https://treeherder.mozilla.org/logviewer?job_id=433552496&repo=autoland&lineNumber=3058

Comment 4

[Makoto Kato [:m_kato]]

(In reply to Narcis Beleuzu [:NarcisB] from comment #3)

Backed out for Lint failure

Backout link: https://hg.mozilla.org/integration/autoland/rev/75936f589527bc6d8c7a4e9a9a54f1cd7ca77577
Log link: https://treeherder.mozilla.org/logviewer?job_id=433552496&repo=autoland&lineNumber=3058

Hmm, I cannot reproduce this on local.

I guess,

[task 2023-10-24T07:27:02.061Z] > Task :geckoview:testWithGeckoBinariesDebugUnitTest
[task 2023-10-24T07:27:02.061Z] Picked up JAVA_TOOL_OPTIONS: -Dfile.encoding=utf-8
[task 2023-10-24T07:27:06.558Z] 
[task 2023-10-24T07:27:06.558Z] org.mozilla.gecko.util.GeckoBundleTest > jsonConversionShouldWork FAILED
[task 2023-10-24T07:27:06.558Z]     java.lang.NoSuchMethodError at GeckoBundleTest.java:367

But does this depend on new Java compiler issue if taskcluster reproduces this repeatedly? I submit try server job...

Comment 5

[Makoto Kato [:m_kato]]

And If this occur, all build tasks such as https://treeherder.mozilla.org/jobs?repo=autoland&fromchange=7f25d62e49a2325004433386f09955d3c2f64c3c&selectedTaskRun=a5J9HANhQ-y1qSANxRuxzA.0 should be failed, but this is successful...

Comment 6

[Makoto Kato [:m_kato]]

ah, my mistake. I update it

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b2dec8a51f6e
Remove pre-Lollipop conditions from mobile/android. r=jnicol,geckoview-reviewers,eeejay,media-playback-reviewers,aosmond,owlish

Comment 8

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/b2dec8a51f6e