1857745 - LulElf.cpp: using "scoped_ptr" & "Module" are unused

Status: RESOLVED FIXED

(Core :: Gecko Profiler, task, P3)

Description

[Sylvestre Ledru [:Sylvestre]]

Filling as a good first bug to learn workflows.

https://searchfox.org/mozilla-central/source/mozglue/baseprofiler/lul/LulElf.cpp#89
https://searchfox.org/mozilla-central/source/mozglue/baseprofiler/lul/LulElf.cpp#90

 using decl 'scoped_ptr' is unused 
 using decl 'Module' is unused 

Tutorial to contribute:
https://firefox-source-docs.mozilla.org/contributing/contribution_quickref.html
https://firefox-source-docs.mozilla.org/contributing/stack_quickref.html

Comment 1

[Ajay]

Hello Sylvestre Ledru [:Sylvestre] I'm an outrechy applicant. I tried working on the issue I made the code changes , when I tried to commit it shows nothing changed
I'm still new to Mercurial

Comment 2

[Ajay]

I explored potential solutions, such as those suggested in this Stack Overflow thread

Comment 3

[Sylvestre Ledru [:Sylvestre]]

you should read:

https://firefox-source-docs.mozilla.org/contributing/contribution_quickref.html
https://firefox-source-docs.mozilla.org/contributing/stack_quickref.html

if you are struggling with hg, please use git :)

Comment 4

[Ajay]

I can't use git directly
I assume this is the command to install git: python3 bootstrap.py --vcs=git I can't use git directly
https://firefox-source-docs.mozilla.org/setup/linux_build.html

Comment 5

[Sylvestre Ledru [:Sylvestre]]

you will find the answers to these questions in the doc ;)
Sorry but it is the best way to learn (reading docs :)

Comment 6

[Ajay]

Attachment: Bug 1857745 - Remove scoped_ptr & Module as they are unused.r?Sylvestre Ledru

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/dfa7261c42ce
Remove scoped_ptr & Module as they are unused.r=sylvestre Ledru

Comment 8

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/dfa7261c42ce