Closed
Bug 1857751
Opened 1 year ago
Closed 1 year ago
nsTSubstring.cpp: do not use 'else' after 'return'
Categories
(Core :: XPCOM, task)
Core
XPCOM
Tracking
()
RESOLVED
FIXED
120 Branch
| Tracking | Status | |
|---|---|---|
| firefox120 | --- | fixed |
People
(Reporter: Sylvestre, Assigned: superchausette, Mentored)
References
(Blocks 1 open bug)
Details
(Keywords: good-first-bug, Whiteboard: [lang=C++])
Attachments
(1 file, 1 obsolete file)
Filling as a good first bug to learn workflows.
do not use 'else' after 'return':
https://searchfox.org/mozilla-central/source/xpcom/string/nsTSubstring.cpp#519-524
As the change is trivial, it is just to learn how to contribute to Firefox.
Found by http://clang.llvm.org/extra/clang-tidy/checks/readability-else-after-return.html
Tutorial to contribute:
https://firefox-source-docs.mozilla.org/contributing/contribution_quickref.html
https://firefox-source-docs.mozilla.org/contributing/stack_quickref.html
Please don't ask for the bug to be assigned. It will be automatically assigned to the first patch.
|
Reporter | |
Updated•1 year ago
|
Mentor: sledru
|
||
Updated•1 year ago
|
Assignee: nobody → superchausette
Status: NEW → ASSIGNED
|
|
||
Updated•1 year ago
|
Attachment #9358491 -
Attachment is obsolete: true
|
|
||
Updated•1 year ago
|
Attachment #9358489 -
Attachment description: Bug 1857751 - Do not use 'else' after 'return'. r?sylvestre → Bug 1857751 - nsTSubstring.cpp: Do not use 'else' after 'return'. r?sylvestre
Pushed by sledru@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/2779c8c81520
nsTSubstring.cpp: Do not use 'else' after 'return'. r=sylvestre
|
||
Comment 4•1 year ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 1 year ago
status-firefox120:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 120 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•