185790 - Impossible to remove JavaScript Events in Composer

Status: VERIFIED FIXED

Description

[Manuel Reimer]

User-Agent:       Mozilla/5.0 (Windows; U; Win98; en-US; rv:1.1) Gecko/20020826
Build Identifier: Mozilla/5.0 (Windows; U; Win98; en-US; rv:1.1) Gecko/20020826

If I have created a link with JavaScript Events in Composer, then it's
impossible to remove this Events in the preferences-window

Reproducible: Always

Steps to Reproduce:
1. Open Composer
2. Press Ctrl+L to open Link-Window
3. Enter a Link-Text
4. Enter a URL
5. Click on "Advanced Edit"
6. Click on the Tab "JavaScript Events"
7. Select a Attribute
8. Enter a value
9. Close all Windows with OK
10. Click in your Link and press Ctrl+L again
11. Click on "Advanced Edit"
12. Select the tab "JavaScript Events"
13. Select the Event in the list and click remove
14. Close the Windows with OK again
15. Open the Properties for that Link again
16. If you check the "JavaScript Events" in "Advanced Edit" then the Event isn't
removed
Actual Results:  
The JavaScript-Event still exists. It's impossible to remove it with the
Preferences-Window

Expected Results:  
The JavaScript-Event should be removed after clicking on "Remove"

I have the same problem with Mozilla 1.2.1

Comment 1

[Kathleen :Brade]

-->brade for triage

Comment 2

[Kathleen :Brade]

confirming; I see this on my debug mac build

Comment 3

[Rafael Ebron (:rebron)]

Composer triage team: nsbeta1+/adt3

Comment 4

[[e-mail]]

Created attachment 114203 [details] [diff] [review]
Proposed patch

This fixes the code in EdAEJSEAttributes.js so that it matches the equivalent
code in EdAEHTMLAttributes.js

Comment 5

[Kathleen :Brade]

Comment on attachment 114203 [details] [diff] [review]
Proposed patch

r=brade
does EdAECSSAttributes.js have the same problem?

Comment 6

[Kathleen :Brade]

-->neil since he has a patch

Comment 7

[[e-mail]]

Comment on attachment 114203 [details] [diff] [review]
Proposed patch

Low risk patch, just copied code from working tab of dialog.

Comment 8

[Asa Dotzler [:asa]]

Comment on attachment 114203 [details] [diff] [review]
Proposed patch

a=asa (on behalf of drivers) for checkin to 1.3 final.

Comment 9

[[e-mail]]

Fix checked in.

Comment 10

[sairuh (rarely reading bugmail)]

vrfy'd fixed --js event is removed from both the advance link properties dlg as
well as the source itself. tested with 2003.02.19.