1857927 - Doh telemetry event ping is not recorded

Status: RESOLVED INVALID

(Core :: Networking: DNS, defect, P2)

Description

[Ardelean Oana, Desktop Test Engineering [:oardelean]]

Attachment: policies.json

Notes

• We are regularly running a Networking test that was passed in earlier builds, but failed in the latest beta build, this bug was logged with this reasoning in mind.

Found in

• Beta 119.0b6;

Affected versions

• Beta 119.0b6;

Tested platforms

• Windows 10;
• Ubuntu 22;
• macOS 13;

Affected platforms

• Windows 10;
• Ubuntu 22;
• macOS 13;

Unaffected platforms

• N/A;

Preconditions

• doh-rollout.home-region to US

Steps to reproduce

1. Open the folder where Firefox is installed.
2. Create a new folder titled distribution and add the attached policies.json file.
3. Open the browser and navigate to about:policies and confirm the DNSOverHTTPS policy is active.
4. Navigate to about:config and add the doh-rollout.enabled boolean pref with the true value.
5. Restart the browser.
6. Navigate to about config and confirm the value of network.trr.mode is 2.
7. Navigate to about:config and confirm that the value of network.trr.uri is https://mozilla.cloudfare-dns.com/dns-query .
8. Navigate to about:telemetry and observe the events.

Expected result

• A similar event ping should be displayed:

category: doh
method: evaluate_v2
object: heuristics
value: enable_doh
extra: {"evaluateReason": "startup", "steeredProvider": "", "captiveState": "not_captive", "networkID": "sRcGeOhzXINUV59AQZLZgHzMOdvIv/LTEMl4+s3C1UA=", "canaries": "", "filtering": "", "enterprise": ""}

Actual result

• No event ping registered.

Regression range

• Will look for one ASAP.

Comment 1

[BugBot [:suhaib / :marco]]

:oardelean, if you think that's a regression, could you try to find a regression range using for example mozregression?

Comment 2

[Ardelean Oana, Desktop Test Engineering [:oardelean]]

manual regression range results:

• last good: 2023-09-14-09-38-29
• first bad: 2023-09-14-21-58-3
• pushlog: https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=c57de172952ed6dfa84943bd2175574e4c87e92b&tochange=71df25fbac58fb3bd1a743700efb73f291e1712a
• potentially regressed by: bug 1784258

Comment 3

[BugBot [:suhaib / :marco]]

Set release status flags based on info from the regressing bug 1784258

Comment 4

[Donal Meehan [:dmeehan]]

:valentin we are in the final week of beta for Fx119.
Do we expect a fix for this to land this week and make it in time for a beta uplift?
Or, will this come in a later release

Comment 5

[Valentin Gosu [:valentin]]

@Oana, I think this specific scenario was a bug before.
If an enterprise policy sets the TRR mode and URI, in that case we really shouldn't run heuristics at all.
Please let me know if you disagree.

I would instead change the testcase to be:
Set a policy enabled, URL: https://dns0.eu/ region US
Make sure that the provider is dns0.eu and not something from heuristics.

@Donal, I think we might end up closing this as INVALID as WONTFIX. I believe the new behaviour is actually the correct one.

Comment 6

[Ardelean Oana, Desktop Test Engineering [:oardelean]]

Thank you for answering, Valentin. We will update the test accordingly. Please feel free to close this bug as you see fit.

Comment 7

[Valentin Gosu [:valentin]]

Thank you, Oana! Please let me know if you find any other issues.
Cheers!