Shopping UX Feedback - Beta label margin fix
Categories
(Fenix :: Shopping, defect, P2)
Tracking
(firefox118 wontfix, firefox119 wontfix, firefox120 verified)
People
(Reporter: 007, Assigned: 007)
References
Details
(Whiteboard: [fxdroid] [fakespot-android-mvp] )
Attachments
(1 file)
Beta label has more margin spacing then in the Figma design. Please examine the dimensions here
Assignee | ||
Updated•1 year ago
|
Updated•1 year ago
|
Assignee | ||
Updated•1 year ago
|
Assignee | ||
Comment 1•1 year ago
|
||
I should have double checked the implementation on this one before filing the ticket. The beta label is correctly following the figma. Left a comment in the QA figma with the findings and will close this ticket when this is resolved.
Comment 2•1 year ago
|
||
Assignee | ||
Comment 3•1 year ago
|
||
Synced up with Kate. There was an issue with the padding of the beta label container showing the incorrect values (12 and 4). The correct values were obtained by inspecting the beta text element itself (8 and 3).
Comment 4•1 year ago
|
||
Authored by https://github.com/MozillaNoah
https://github.com/mozilla-mobile/firefox-android/commit/51855bc87ed227c3272c96f213c46d7168b9aa0b
[main] Bug 1857984 - Reduce beta label padding
Comment 5•1 year ago
|
||
Verified as fixed on the latest Fenix Nightly 120.0a1 from 10/11 with Google Pixel 6 (Android 14), and Xiaomi Mi 8 Lite (Android 10).
Updated•1 year ago
|
Description
•