1858018 - Re-analysis progress doesn't persist when closing and reopening the bottom sheet

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: Shopping, enhancement, P2)

Description

[Verdi [:verdi] Best to slack me]

Attachment: re-analysis-progress-lost.mp4

Steps to reproduce

1. Find a product that has out of date analysis
2. Click to update analysis - observe the spinner
3. Close the sheet and immediately open it again

Expected behavior

The progress spinner should still be displayed

Actual behavior

A prompt to begin the re-analysis is present

Device information

• Firefox version: 120.0a1 (Build #2015978850)
• Android device model: Samsung Galaxy S9
• Android OS version: 10

Any additional information?

Comment 1

[Rahul Sainani [:rsainani]]

When the bottom sheet is closed, we are off to another screen, we don't hold the state of what was happening before. Even though backend is still processing. Since backend still returns the same response, client displays the same information.

Comment 2

[Verdi [:verdi] Best to slack me]

(In reply to Rahul Sainani [:rsainani] from comment #1)

When the bottom sheet is closed, we are off to another screen, we don't hold the state of what was happening before. Even though backend is still processing. Since backend still returns the same response, client displays the same information.

Talk to the desktop engineers? I think we need to find some way to make this work. The following works on desktop:

1. Find a product that has an outdated analysis
2. Copy the url
3. Start the analysis
4. Close the tab
5. Open a new tab and paste in the url
6. Notice that the analysis is still in progress

Comment 3

[Verdi [:verdi] Best to slack me]

This works as desired on iOS too.

Comment 4

[BMO Github Automation]

Attachment: [mozilla-mobile/firefox-android] Bug 1858018 - Persist review checker reanalysis state (#4059)

Comment 5

[BMO Github Automation]

Authored by https://github.com/rahulsainani
https://github.com/mozilla-mobile/firefox-android/commit/d012d7cf50b2b0633cdfd18c413f0ca2f2bfd08d
[main] Bug 1858018 - Persist review checker reanalysis state

Comment 6

[Adina Petridean QA [:apetridean]]

Verified as fixed on Nightly 120.0a1 from 10/17 with Poco M4 Pro (Android 12) and OnePlus A3000 (Android 6).

Comment 7

[Adina Petridean QA [:apetridean]]

Attachment: re-analysis.mp4