1858099 - Screenshot fails to download for pages with long titles (file path is too long)

Status: RESOLVED DUPLICATE of bug 1818862

(Firefox :: Screenshots, defect)

Description

[Kestrel]

STR:

1. Start Nightly 120.0a1 on Ubuntu 23.04.
2. Visit https://www.amazon.com/Complete-Collection-Anniversary-Editions-Anniversay/dp/B00MRH3RYU/.
3. Take a screenshot of a region (Ctrl+Shift+S).
4. Click the Download button.

Download fails with console error:

DOMException: Target file path is too long DownloadCore.sys.mjs:1751:17
 refreshPartFileState resource://gre/modules/DownloadCore.sys.mjs:1751
DOMException: Could not remove the file at /home/<user>/Downloads/Screenshot 2023-10-09 at 16-03-04 A Complete Foxfire Series 14-Book Collection Set with Anniversary Editions (Volumes 1 2 3 4 5 6 7 8 9 10 11 and 12 plus 40th and 45th Anniversay Editions) Eliot Wigginton George P. Reynolds Kaye Carver Collins 08[...].png.part DownloadCore.sys.mjs:2637:19
 _tryToRemoveFile resource://gre/modules/DownloadCore.sys.mjs:2637

Page title is 256 characters long:

A Complete Foxfire Series 14-Book Collection Set with Anniversary Editions (Volumes 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11 and 12 plus 40th and 45th Anniversay Editions): Eliot Wigginton, George P. Reynolds, Kaye Carver Collins: 0852687849171: Amazon.com: Books

It also fails on Windows but does not produce an error in the console.

Regression window:
https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=7a264eeeb866491cb9550c2fcb316aa7c6e8548b&tochange=d2c1a952505d43c989b412f9b1e02de733cfd9be

Possibly regressed by Bug 1744779.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

:enndeakin, since you are the author of the regressor, bug 1744779, could you take a look? Also, could you set the severity field?

For more information, please visit BugBot documentation.

Comment 2

[Sam Foster [:sfoster] (he/him)]

This looks like the same issue as bug 1818862, where the filename + path to download directory ends up exceeding the MAX_PATH, which causes the download to file as we can't write the file at that location.

There is a work-in-progress patch on the other bug. When we get that landed, we'll come back here to double-check these STR are also resolved.