1858183 - Screen Reader Fails to Read Confirmation Dialog Text in 'End Private Session'

Status: VERIFIED FIXED

(Firefox :: Private Browsing, defect, P1)

Description

[Simona Badau, Desktop QA, PTO 13-25aug]

Found in

• Nightly 120.0a1

Affected versions

• Nightly 120.0a1

Tested platforms

• Affected platforms: macOS 11.7, Ubuntu 22.04 x64, Windows 10 x64.

Preconditions

• Open the Screenreader before opening Firefox:

• on Windows 10 - NVDA
• on macOS - Voice Over
• on Ubuntu - integrated screen reader.

Steps to reproduce

1. Open a private window.
2. Use the screen reader to reach the "End Private Session" button and open the Confirmation panel.

Expected result

• The button and the information from the Confirmation panel (including the check box and buttons) should be read by the screen reader.

Actual result

• While the screen reader successfully reads the "Always ask me" checkbox and the buttons, it does not read the text within the Confirmation dialog: "End your private session? Close all private tabs and delete history, cookies, and all other site data."

Regression range

• Not a regression.

Additional notes

• When using VoiceOver on Mac OS, I could access the text, but it was part of a different group, necessitating navigation through the Extensions and Open App Menu buttons before reaching the text, which might be confusing for the users.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

:sbadau, if you think that's a regression, could you try to find a regression range using for example mozregression?

Comment 2

[Anna Yeddi [:ayeddi]]

This is an interesting behavior of the panel - with NVDA, I was not able to read the heading and the text of the panel, at all. Reading content is not possible: Down/Up arrows are overwritten and just follow the Tab key behavior. It was not an issue of a screen reader going into Forms mode (it would've beeped and NVDA+Space/Ins+Space would've returned it to Browse mode and unlock the Down/Up arrows).

:Timhuang, I'm marking it as access-S2 because the labels of the panel toggle and checkbox a bit explanatory, but the behavior is basically blocked for a screen reader user (like our target NVDA and, likely, JAWS too) and significantly hard for VoiceOver users too. Resolving this should be high priority in order to avoid shipping a blocker.

Plus, the dialog is missing programmatic structure (no role and accessible name) and the visual heading is not marked up as such, thus nothing is announced when the panel is opened and the focus is moved in there. Expected behavior and structure can be found in the WAI ARIA pattern

Comment 3

[BugBot [:suhaib / :marco/ :calixte]]

The severity field for this bug is set to S3. However, the accessibility severity is higher, .
:timhuang, could you consider increasing the severity?

For more information, please visit BugBot documentation.

Comment 4

[Emma Zühlcke [:emz]]

Attachment: Bug 1858183 - Assign proper a11y roles to elements in reset PBM panel. r=#accessibility-frontend-reviewers!

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f048e9ea9320
Assign proper a11y roles to elements in reset PBM panel. r=ayeddi,desktop-theme-reviewers,dao

Comment 6

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/f048e9ea9320

Comment 7

[Simona Badau, Desktop QA, PTO 13-25aug]

I can confirm that the confirmation dialog is now being read on the latest Nightly 120.0a1 build - verified on Windows 10, macOS 11.7, and Ubuntu 22.04 x64. However, I have encountered some behaviors that I'm uncertain about:

1. On Windows 10 with NVDA, the following information is read: "Firefox Nightly Private Browsing; Navigation ToolBar; Document; End your private session?; Dialog Close all private tabs and delete history, cookies, and all other site data; Always ask me Check box checked Alt+A; End your private session? Check box checked Alt+A Always ask me; Button Alt+D Delete session data, Button Alt+C Cancel."

Is it intended for "Document" to be announced at the beginning and for the "End your private session? Ckecked box checked Alt+A Always ask me" to be repeated?

2. On macOS 11.7 - the heading 'End your session?' is only read the first time the dialog is reached and is not repeated if the user navigates to it using the Up arrow key. For more details, please see the video.

3. On Ubuntu - only the "End your private session dialog" is read, and it is followed by "Always ask me" with the "check box" checked. The text "Close all private tabs and delete history, cookies, and all other site data" is not announced. I'm unsure whether this behavior is due to a limitation in the screen reader, as I observe the same behavior with the Pocket button.

Paul, could you please take a look and let me know if any of the behaviors mentioned above are considered expected or if I should proceed and log any additional bugs?

Comment 8

[Simona Badau, Desktop QA, PTO 13-25aug]

I'm marking this as "Verified Fixed" as the Confirmation dialog text is now read in the latest Nightly 120.0a1 - verified on macOS 11.7, Windows 10 and Ubuntu 22.04. Additionally, I've logged Bug 1860261 and Bug 1860285 to address the remaining issues (I believe the problem mentioned in point 3 is related to the Ubuntu screen reader rather than being a Firefox issue).

Comment 9

[Emma Zühlcke [:emz]]

Thanks for filing those additional bugs! Worth keeping track of, but not blocking IMO.