1858200 - Malloc allocated data can grow without bound when running wasm

Status: RESOLVED FIXED

(Core :: JavaScript: GC, defect, P1)

Description

[Jon Coppeard (:jonco)]

jseward has a case where allocating nursery GC things with malloc data attached can lead to unbounded memory increase when running purely in wasm.

Normally we track the amount of malloc data attached to GC things and request an interrupt to trigger a major GC when the total size passes a threshold. I suspect the reason this isn't working is that we don't check for this interrupt from wasm. We do explicitly check for requested major GC when allocating tenured GC things, but it's possible for this not to happen.

Comment 1

[Jon Coppeard (:jonco)]

Attachment: Bug 1858200 - Interrupt wasm when a major GC is requested r?jandem

Currently wasm ignores GCs triggered by allocation, which can lead to unbounded
memory growth when running purely in wasm. Making the GC interrupt also
interrupt wasm fixes this.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b8fc1c079a23
Interrupt wasm when a major GC is requested r=jandem

Comment 3

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/b8fc1c079a23