Closed Bug 1858361 Opened 2 years ago Closed 2 years ago

Call CanvasContext::SwapChainPresent() from ShareableCanvasRenderer::UpdateCompositableClient()

Categories

(Core :: Graphics: WebGPU, enhancement)

enhancement

Tracking

()

RESOLVED FIXED
122 Branch
Tracking Status
firefox122 --- fixed

People

(Reporter: sotaro, Assigned: sotaro)

References

Details

Attachments

(1 file, 1 obsolete file)

CanvasContext::MaybeQueueSwapChainPresent() triggers to present swap chain by posting Runnable to current thread.
It could cause to skip to present CommandBuffer::Commit() rendering result multiple times. It depends on timing.

CommandBuffer::Commit() is called in Queue::Submit(). Then it seem better to present swap chain just after PWebGPUChild::SendQueueSubmit().

Component: Graphics → Graphics: WebGPU
Assignee: nobody → sotaro.ikeda.g
Blocks: 1856787
Attachment #9357775 - Attachment is obsolete: true
Summary: Request to present swap chain just after PWebGPUChild::SendQueueSubmit() → Call CanvasContext::SwapChainPresent() from ShareableCanvasRenderer::UpdateCompositableClient()

It seems better to call CanvasContext::SwapChainPresent() from ShareableCanvasRenderer::UpdateCompositableClient() like other canvases.

Pushed by sikeda.birchill@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/c9c3025f1539 Call CanvasContext::SwapChainPresent() from ShareableCanvasRenderer::UpdateCompositableClient() r=gfx-reviewers,nical
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → 122 Branch
Regressions: 1869692
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: