1858362 - Style invalidation after call to CSS.registerProperty

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, defect)

Description

[Frédéric Wang (:fredw)]

Attachment: custom-property-invalidation-after-register-property.html

See the attached testcase, after CSS.registerProperty calls, --my-visibility and --my-display should use initial values hidden and none respectively so the "FAIL" messages shouldn't show up. This works in WebKit and Chrome.

There is a similar WPT registered-property-change-style-001.html test in interop 2023 that has always been failing in Firefox: https://wpt.fyi/results/css/css-properties-values-api/registered-property-change-style-001.html?label=master&label=experimental&product=chrome&product=firefox&product=safari&aligned&view=interop&q=label%3Ainterop-2023-property

Comment 1

[Frédéric Wang (:fredw)]

Attachment: custom-property-invalidation-after-at-property-appended.html

Same test using @property instead. This currently works in Firefox.

Comment 2

[Frédéric Wang (:fredw)]

@Emilio: I guess I need to add some invalidation call in Servo_RegisterCustomProperty. I can investigate later, but do you have some quick hints about how to do that?

Comment 3

[Emilio Cobos Álvarez (:emilio)]

You want a block like this but in the caller (probably only when RegisterProperty succeeds.

Instead of RestyleSubtree I think RecascadeSubtree would be enough to pick up the initial values.

Comment 4

[Frédéric Wang (:fredw)]

Attachment: Bug 1858362 - Style invalidation after call to CSS.registerProperty. r=emilio

Call to CSS.registerProperty may result in rendering changes compared
to when variables were interpreted as unregistered custom properties.
Ensure we recascade style for the whole document tree.

This was already covered by WPTs but add a more direct check for
paint and reflow.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8dbb04b2762b
Style invalidation after call to CSS.registerProperty. r=emilio

Comment 6

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/42481 for changes under testing/web-platform/tests

Comment 7

[Sandor Molnar[:smolnar]]

Backed out for causing wpt failures on /css/css-properties-values-api/register-property.html

Backout link: https://hg.mozilla.org/integration/autoland/rev/f4b206937d6b197ce918eb811071e5222b4ecabc

Push with failures

Failure log -> TEST-UNEXPECTED-PASS | /css/css-properties-values-api/register-property.html | Registering a property should not cause a transition - expected FAIL

Comment 8

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR was closed without merging

Comment 9

[Frédéric Wang (:fredw)]

It seems more tests pass after the recent changes Zach landed.

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1b47cd29b7c3
Style invalidation after call to CSS.registerProperty. r=emilio

Comment 11

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/1b47cd29b7c3

Comment 12

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot