1858375 - [win11] The chevron arrows from How we determine review quality and Settings have a frame with Night sky Contrast theme

Status: VERIFIED FIXED

(Firefox :: Shopping, defect, P2)

Description

[Alexandru Trif, Desktop Test Engineering [:atrif]]

Attachment: image.png

Found in

• 119.0b7

Affected versions

• 120.0a1 (2023-10-10)
• 119.0b7

Tested platforms

• Affected platforms: Windows 11x64
• Unaffected platforms: Ubuntu 22.1, macOS 12, Windows 10x64

Preconditions

• Contrast theme set to Night Sky

Steps to reproduce

1. Open a random amazon product and observe the review checker.
2. Compare the review checker with Figma

Expected result

• The chevron arrows from How we determine review quality and Settings have a frame.

Actual result

• The chevron arrows from How we determine review quality and Settings do not have a frame.

Regression

• Not applicable

Additional notes

• Attached a screenshot.
• This applies to all review checker states.

Comment 1

[kpatenio]

Given the changes in my patch for Bug 1858374 (ex. adding background color on hover), I may take this bug as well and integrate the fix in that patch instead. Otherwise, the accordion will look odd in HCM if we don't remove the chevron border in parallel.

Comment 2

[Anna Yeddi [:ayeddi]]

With the current implementation of these chevron buttons, either having the entire disclosure button to have a border and ButtonText+ButtonFace colors or only the chevrons would be acceptable for HCM. The Figma HCM design would be required if the chevrons are not focusable like they are in the Fx View, but since they are their own controls, they could have their button styling to communicate to a mouse user that they could be clicked and activated. Thus, access-s4, but I also would be okay with closing the bug too, based on the existent implementation of this complex control

Comment 3

[kpatenio]

Given that Bug 1858374 was fixed, I'm going to resolve this as FIXED too.

Comment 4

[Alexandru Trif, Desktop Test Engineering [:atrif]]

Verified fixed with Firefox 122.0a1 (2023-12-06) on Windows 11x64. The chevron arrows from How we determine review quality and Settings no longer have a frame with Night sky Contrast theme after following STR from comment 0. Setting statues based on bug 1858374.