1858390 - Fetching child process crash annotations is largely broken on Android

Status: RESOLVED FIXED

(Toolkit :: Crash Reporting, defect)

Description

[Gabriele Svelto [:gsvelto]]

This is another effect of the interaction between the new crash annotations machinery and elfhack. From what I can tell it mostly doesn't work on Android, very few crashes come with annotations since I landed bug 1776197.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1776197

Comment 2

[Gabriele Svelto [:gsvelto]]

Quite ironically we have tests covering this but they didn't trigger because the build we use for them was apparently unaffected.

Comment 3

[Gabriele Svelto [:gsvelto]]

Attachment: Bug 1858390 - Fix fetching crash annotations when using elfhack r=glandium

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a0bf5c968d8b
Fix fetching crash annotations when using elfhack r=glandium

Comment 5

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/a0bf5c968d8b

Comment 6

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:gsvelto, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
• If no, please set status-firefox119 to wontfix.

For more information, please visit BugBot documentation.

Comment 7

[Gabriele Svelto [:gsvelto]]

Comment on attachment 9358060 [details]
Bug 1858390 - Fix fetching crash annotations when using elfhack r=glandium

Beta/Release Uplift Approval Request

• User impact if declined: Users are not affected directly, but crash reports from Android and some Linux users are missing important information
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): This code is well covered with tests and is only exercised after one of the child processes crashed
• String changes made/needed: none
• Is Android affected?: Yes

Comment 8

[Donal Meehan [:dmeehan]]

Comment on attachment 9358060 [details]
Bug 1858390 - Fix fetching crash annotations when using elfhack r=glandium

Thanks for the uplift request. Moving to release since Fx119 is now in RC.
This will be uplifted for 119.0 RC2

Comment 9

[Donal Meehan [:dmeehan]]

Comment on attachment 9358060 [details]
Bug 1858390 - Fix fetching crash annotations when using elfhack r=glandium

Approved for 119.0 RC2

Comment 10

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-release/rev/2af6a1c64f0d