1858409 - Special-case context menus where additional, OS-provided menu items such as "Services" and "Autofill" should be displayed

Status: RESOLVED FIXED

(Core :: Widget: Cocoa, defect, P3)

Description

[Julian Descottes [:jdescottes]]

Minor UI issue, probably macos only?

STRs:

• open network panel
• anywhere in the panel, select and highlight some text (for instance, the "Disable Cache" label of the cache checkbox)
• open the throttling menu

ER: only the throttling menu items should be displayed
AR: a "Services" submenu appears with random options

Comment 1

[Julian Descottes [:jdescottes]]

Attachment: image.png

Comment 2

[Julian Descottes [:jdescottes]]

This actually happens with context menus outside of devtools, and also the text doesn't have to be selected in devtools, it can be anywhere in the application (eg in the content page).

STRs without devtools:

• open a page
• select some text in it
• right click on an empty area of the Firefox toolbar

The "Services" context menu shows up.

Confirmed to be macos only, maybe Core:Widget Cocoa can be a good fit.

Comment 3

[Stephen A Pohl [:spohl]]

This is an OS-provided context menu entry and it was intentionally enabled in bug 660452. The Services menu may not always be very helpful as seen in the example here, but this is otherwise as designed.

Comment 4

[Markus Stange [:mstange]]

I disagree with this assessment. For example, right-clicking the regular browser toolbar also shows the Services menu depending on whether text is selected in content or not. This is something that doesn't affect other applications. For example, in Chrome, if you select something in a website then you get the Services menu only if you open the context menu in content, but not if you open it on the tab bar.

We may want to special-case menus that should show the Services item. For example, we could consider including it only in the "content area context menu" and in textbox context menus.

Comment 5

[Stephen A Pohl [:spohl]]

(In reply to Markus Stange [:mstange] from comment #4)

We may want to special-case menus that should show the Services item. For example, we could consider including it only in the "content area context menu" and in textbox context menus.

I did this consider as well, but couldn't come up with a particularly good way to do so. Let's try it.

Comment 7

[:Gijs (he/him)]

Attachment: Bug 1858409 - only show autofill/services menus when appropriate, r?#mac-reviewers

Comment 8

[:Gijs (he/him)]

I nearly filed a dupe of this the other week because it's confusing/annoying, so I'm going to submit a patch.

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/defc29887984
only show autofill/services menus when appropriate, r=mac-reviewers,reusable-components-reviewers,mstange,emilio,tgiles

Comment 10

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/defc29887984