Categories
(Webtools :: Searchfox, enhancement)
Tracking
(Not tracked)
People
(Reporter: asuth, Assigned: asuth)
References
Details
We've talked about how we should index mozsearch and mozsearch-mozilla on searchfox.org, but I don't think we've ever actually tracked it. It would be great to index these repositories. config1 seems like the obvious choice for this but I do worry that this might be one of our more brittle jobs, so I could see an argument for putting it on config2 for release, although setting "on_error" to "continue" in the config file may be sufficient.
For testing runs I've mainly been using just-mc.json but maybe we could expand that to include mozsearch and call it smoketest.json or something like that which expresses that when we do a run to help people test or review things that it should also include mozsearch proper in order to avoid surprises on landing.
We do already have a build-searchfox-repo target in the Makefile which uses the testing searchfoxc-config.json, but it doesn't actually perform the meaningful indexing that we'd want. The setup script does build the blame data we want, but that's mainly all we've used the target for (testing blame). A recent major improvement is that Emilio did add indexing our rust code to the build script, but we don't index MozsearchIndexer.cpp, which I think is the main gap. Although we could also try and index our python code too once I land scip-indexer.
In terms of indexing the tests which we index via make build-test-repo, maybe that should be a separate config? Like we'd have mozsearch, mozsearch-mozilla, and mozsearch-tests which is the tests subtree from mozsearch? Alternately, we could index the tests as part of mozsearch... since we should detect the tests as tests for "pathkind" purposes (which means they go under a different top-level group in search results), maybe that's fine if it's easy enough to do?
|
Assignee | |
Updated•4 months ago
|
|
|
Assignee | |
Comment 1•4 months ago
|
||
This landed and stuck:
https://github.com/mozsearch/mozsearch/pull/783
https://github.com/mozsearch/mozsearch-mozilla/pull/257
It could potentially make sense to also modify the README.md to link to the self-index.
Description
•