1858468 - Don't compute custom properties twice inside links.

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, enhancement)

Comment 1

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1858468 - Don't compute custom properties twice inside links. r=dshin,#style,#layout

This matches the behavior of other browsers (in fact, I filed 1 about
it long time ago).

This avoids a bunch of overhead in some speedometer subtests. Makes me a
bit sad because I still think our approach is slightly more correct per
spec, but not worth the performance cost.

Comment 2

[Emilio Cobos Álvarez (:emilio)]

https://treeherder.mozilla.org/perfherder/compare?originalProject=try&originalRevision=93798bc3a2bb2cb0c3a305ad2e117ad1b01953d5&newProject=try&newRevision=7cf9c44924b45fc1200a3cccbe50ea9cc73b4ab7

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e136cc989327
Don't compute custom properties twice inside links. r=dshin

Comment 4

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/e136cc989327

Comment 5

[Andrej (:aglavic)]

(In reply to Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout) from comment #4)

https://hg.mozilla.org/mozilla-central/rev/e136cc989327

== Change summary for alert #40023 (as of Mon, 23 Oct 2023 23:05:57 GMT) ==

Improvements:

Ratio	Test	Platform	Options	Absolute values (old vs new)
14%	perf_reftest_singletons style-attr-1.html	windows10-64-shippable-qr	e10s fission stylo webrender	4.08 -> 3.52
10%	perf_reftest_singletons style-attr-1.html	windows10-64-shippable-qr	e10s fission stylo webrender	4.01 -> 3.62

For up to date results, see: https://treeherder.mozilla.org/perfherder/alerts?id=40023

Comment 6

[Karl Tomlinson (:karlt)]

== Change summary for alert #40024 (as of Mon, 23 Oct 2023 23:29:16 GMT) ==

Improvements:

Ratio	Test	Platform	Options	Absolute values (old vs new)
17%	perf_reftest style-attr-1.html	windows10-64-shippable-qr	e10s fission stylo webrender	2.93 -> 2.43
16%	perf_reftest style-attr-1.html	windows10-64-shippable-qr	e10s fission stylo webrender	2.93 -> 2.48

For up to date results, see: https://treeherder.mozilla.org/perfherder/alerts?id=40024