1858622 - Freeze/seal more JS standard classes in freezeBuiltins realms

Status: RESOLVED FIXED

(Core :: JavaScript Engine, task)

Description

[Jan de Mooij [:jandem]]

We did this for Object/Array/Function for security reasons in bug 1771084, but we can extend this to other builtins.

Comment 1

[Jan de Mooij [:jandem]]

Attachment: Bug 1858622 - Freeze/seal more JS standard classes in freezeBuiltins realms. r?mgaudet!

We did this for Object/Array/Function for security reasons in bug 1771084, but we can
extend this to other builtins.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a64fd92f37f7
Freeze/seal more JS standard classes in freezeBuiltins realms. r=mgaudet

Comment 3

[Cristina Horotan [:chorotan]]

Backed out changeset a64fd92f37f7 (bug 1858622) for causing xpcshell failures at test_quicksuggest_impressionCaps.js

Backout: https://hg.mozilla.org/integration/autoland/rev/0db2502d9e9503580a800e13235be8c02043bbc0

Failure push: https://treeherder.mozilla.org/jobs?repo=autoland&group_state=expanded&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel&revision=a64fd92f37f74580e1219013306a7646ebb51763&selectedTaskRun=MFYO-l7qTRaV36VrMMwMjA.0

Failure logs:
https://treeherder.mozilla.org/logviewer?job_id=432365104&repo=autoland&lineNumber=3800
https://treeherder.mozilla.org/logviewer?job_id=432367917&repo=autoland&lineNumber=4246

Comment 4

[Jan de Mooij [:jandem]]

xpcshell tests are using this Sinon library that overrides Date.now apparently. I relanded this with an exception for Date. Let's see if there are other issues.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/105aa04166a8
Freeze/seal more JS standard classes in freezeBuiltins realms. r=mgaudet

Comment 6

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/105aa04166a8