1858627 - Suppress the paste contextmenu if the paste request is triggered by keyboard shortcut

Status: RESOLVED FIXED

(Core :: DOM: Copy & Paste and Drag & Drop, task)

Description

[Edgar Chen [:edgar]]

(This is split off from bug 1777448)

Comment 1

[Edgar Chen [:edgar]]

Attachment: Bug 1858627 - Suppress the paste contextmenu in paste event handler; r?nika

Depends on D190863

Comment 2

[Edgar Chen [:edgar]]

https://treeherder.mozilla.org/jobs?repo=try&group_state=expanded&revision=35c739dc32d6567a4e98e943267d3da7b918deab

Comment 3

[Edgar Chen [:edgar]]

https://treeherder.mozilla.org/jobs?repo=try&group_state=expanded&revision=869811777455322368ad886b3477978becf43b3c

Comment 4

[Edgar Chen [:edgar]]

https://treeherder.mozilla.org/jobs?repo=try&group_state=expanded&revision=3f69924e1521c976e5338f941ae914f720c628c9

Comment 5

[Edgar Chen [:edgar]]

Attachment: Bug 1858627 - Add nsIClipboard API to return nsIAsyncSetClipboardData synchrously; r?nika!

This is a sync version of nsIClipboard.asyncGetData, which can be used for
synchronous clipboard APIs, e.g. DataTransfer, to support the clipboard seqence
number concept.

Comment 6

[Edgar Chen [:edgar]]

Attachment: Bug 1858627 - Use ManagedEndpoint for PClipboardReadRequest construction; r?nika

Comment 7

[Edgar Chen [:edgar]]

https://treeherder.mozilla.org/jobs?repo=try&group_state=expanded&revision=1b5b144b053914dccc634dd88031c9224bd367d9

Comment 8

[Edgar Chen [:edgar]]

Attachment: Bug 1858627 - Update DataTransfer to utilize GetDataSnapshotSync() for retrieving clipboard formats; r?nika

The actual data retrieval continues to use the original method.

Depends on D201364

Comment 9

[Edgar Chen [:edgar]]

https://treeherder.mozilla.org/jobs?repo=try&group_state=expanded&revision=907428687c1ba36774cbb0b5c8fdd375d8f1ff31

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/05b957fe3079
Use ManagedEndpoint for PClipboardReadRequest construction; r=nika
https://hg.mozilla.org/integration/autoland/rev/1d5175296606
Add nsIClipboard API to return nsIAsyncSetClipboardData synchrously; r=ipc-reviewers,nika
https://hg.mozilla.org/integration/autoland/rev/aca702ea720f
Update DataTransfer to utilize GetDataSnapshotSync() for retrieving clipboard formats; r=nika,ipc-reviewers
https://hg.mozilla.org/integration/autoland/rev/ad694926aa45
Suppress the paste contextmenu in paste event handler; r=nika

Comment 11

[Natalia Csoregi [:nataliaCs]]

Backed out for causing clipboard/paste failures.

• backout: https://hg.mozilla.org/integration/autoland/rev/9d83ccfa64631a8da3e42a5c1d0c2d5f72f4c504
• push: https://treeherder.mozilla.org/jobs?repo=autoland&group_state=expanded&revision=ad694926aa451a86fcdc3a83a7bc49da3f66caa0
• failure logs:
  • TEST-UNEXPECTED-FAIL | dom/events/test/clipboard/test_paste_image.html | undefined assertion name - Structures begin differing at:
  • TEST-UNEXPECTED-FAIL | browser/base/content/test/general/browser_clipboard.js | text/html on clipboard 2 - "text/plain" == "text/html" - got "text/plain", expected "text/html" (operator ==)

Comment 12

[Pulsebot]

Backout by [e-mail]:
https://hg.mozilla.org/mozilla-central/rev/cf015b6f24b4
Backed out 4 changesets for causing clipboard/paste failures. CLOSED TREE

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/02f94f12c3ef
Use ManagedEndpoint for PClipboardReadRequest construction; r=nika
https://hg.mozilla.org/integration/autoland/rev/8f4ca2ab875b
Add nsIClipboard API to return nsIAsyncSetClipboardData synchrously; r=ipc-reviewers,nika
https://hg.mozilla.org/integration/autoland/rev/9efc1874ac78
Update DataTransfer to utilize GetDataSnapshotSync() for retrieving clipboard formats; r=nika,ipc-reviewers
https://hg.mozilla.org/integration/autoland/rev/eaf5e6b7ddd4
Suppress the paste contextmenu in paste event handler; r=nika

Comment 14

[Norisz Fay [:noriszfay]]

Backed out for causing build bustage

Backout link

Push with failures

Failure log

There are TV failures too that turned into test failures: Failure log 1 // Failure log 2

Comment 15

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d3a1b3ac7611
Use ManagedEndpoint for PClipboardReadRequest construction; r=nika
https://hg.mozilla.org/integration/autoland/rev/0655d0feb163
Add nsIClipboard API to return nsIAsyncSetClipboardData synchrously; r=ipc-reviewers,nika
https://hg.mozilla.org/integration/autoland/rev/96327aab8126
Update DataTransfer to utilize GetDataSnapshotSync() for retrieving clipboard formats; r=nika,ipc-reviewers
https://hg.mozilla.org/integration/autoland/rev/7f3f50c77406
Suppress the paste contextmenu in paste event handler; r=nika

Comment 16

[tszentpeteri]

Backed out for causing build bustages with -p style --lib

• Backout link
• Push with failures
• Failure Log
• Failure line: error: test failed, to rerun pass -p style --lib

Comment 17

[Edgar Chen [:edgar]]

https://treeherder.mozilla.org/jobs?repo=try&revision=e6b0d64edd7be47c8fa13299abd01b160f67bb71

Comment 18

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e74c0b9d4629
Use ManagedEndpoint for PClipboardReadRequest construction; r=nika
https://hg.mozilla.org/integration/autoland/rev/eb0448a851ca
Add nsIClipboard API to return nsIAsyncSetClipboardData synchrously; r=ipc-reviewers,nika
https://hg.mozilla.org/integration/autoland/rev/ff1b45cb9a22
Update DataTransfer to utilize GetDataSnapshotSync() for retrieving clipboard formats; r=nika,ipc-reviewers
https://hg.mozilla.org/integration/autoland/rev/2856b3088528
Suppress the paste contextmenu in paste event handler; r=nika

Comment 19

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/e74c0b9d4629
https://hg.mozilla.org/mozilla-central/rev/eb0448a851ca
https://hg.mozilla.org/mozilla-central/rev/ff1b45cb9a22
https://hg.mozilla.org/mozilla-central/rev/2856b3088528